Skip to contentSkip to conversation

rt2x00: remove unused variable

PATCH In review Stefano Brivio 4 participants 8 messages Jan 13, 2008 – Jan 15, 2008 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rt2x00: remove unused variable

Remove an unused variable that caused a warning while building. Please note that the pipe obtained there isn't used anywhere else.

---

drivers/net/wireless/rt2x00/rt2x00usb.c +0 -1
Index: wireless-2.6/drivers/net/wireless/rt2x00/rt2x00usb.c
===================================================================
@@ -176,7 +176,6 @@ int rt2x00usb_write_tx_data(struct rt2x0
 	struct usb_device *usb_dev =
 	    interface_to_usbdev(rt2x00dev_usb(rt2x00dev));
 	struct data_entry *entry = rt2x00_get_data_entry(ring);
-	int pipe = usb_sndbulkpipe(usb_dev, 1);
 	struct skb_desc *desc;
 	u32 length;
 

--
Ciao
Stefano

#1 lore raw

Hi,

Quoted 2 lines

Remove an unused variable that caused a warning while building. Please note that the pipe obtained there isn't used anywhere else.

This patch is in wireless-2.6 already...

Ivo

#2 lore raw
Quoted 6 lines · On Sun, 13 Jan 2008 20:14:53 +0100 Ivo van Doorn <[email protected]> wrote:

Hi,

Quoted 2 lines

Remove an unused variable that caused a warning while building. Please note that the pipe obtained there isn't used anywhere else.

This patch is in wireless-2.6 already...

Actually, I thought I already sent this patch, but couldn't find it anywhere, neither in my outbox nor in git-log. Could you tell me what's the related SHA commit? Thanks.

Signature · 2 lines
Ciao
Stefano
#3 lore raw

Hi.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Remove an unused variable that caused a warning while building. Please note that the pipe obtained there isn't used anywhere else.

This patch is in wireless-2.6 already...

Actually, I thought I already sent this patch, but couldn't find it anywhere, neither in my outbox nor in git-log. Could you tell me what's the related SHA commit? Thanks.

This is in my rt2x00.git log. It is signed off by John and not by me, so that means it didn't go through rt2x00.git to get into the wireless tree. I have merged the patch into rt2x00.git during my last clone from wireless...

commit 01b0258008a73648245dcbc628ff948878c428e0

Author: Stefano Brivio <[email protected]>
Date:   Wed Dec 19 01:43:33 2007 +0100

rt2x00: remove unused variable

Remove an unused variable. Note that the pipe obtained there isn't used as well.

#4 lore raw
Quoted 19 lines · On Sunday 13 January 2008 22:48:47 Ivo van Doorn wrote:

Hi.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Remove an unused variable that caused a warning while building. Please note that the pipe obtained there isn't used anywhere else.

This patch is in wireless-2.6 already...

Actually, I thought I already sent this patch, but couldn't find it anywhere, neither in my outbox nor in git-log. Could you tell me what's the related SHA commit? Thanks.

This is in my rt2x00.git log. It is signed off by John and not by me, so that means it didn't go through rt2x00.git to get into the wireless tree. I have merged the patch into rt2x00.git during my last clone from wireless...

commit 01b0258008a73648245dcbc628ff948878c428e0

Author: Stefano Brivio <[email protected]>
Date:   Wed Dec 19 01:43:33 2007 +0100
Quoted 7 lines

rt2x00: remove unused variable

Remove an unused variable. Note that the pipe obtained there isn't used as well.

I cannot find this commit in wireless-2.6

Signature · 1 line
Greetings Michael.
#5 lore raw
Quoted 22 lines · Michael Buesch
Quoted 21 lines · On Sunday 13 January 2008 22:48:47 Ivo van Doorn wrote:

Hi.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Remove an unused variable that caused a warning while building. Please note that the pipe obtained there isn't used anywhere else.

This patch is in wireless-2.6 already...

Actually, I thought I already sent this patch, but couldn't find it anywhere, neither in my outbox nor in git-log. Could you tell me what's the related SHA commit? Thanks.

This is in my rt2x00.git log. It is signed off by John and not by me, so that means it didn't go through rt2x00.git to get into the wireless tree. I have merged the patch into rt2x00.git during my last clone from wireless...

commit 01b0258008a73648245dcbc628ff948878c428e0

Author: Stefano Brivio <[email protected]>
Date:   Wed Dec 19 01:43:33 2007 +0100

rt2x00: remove unused variable

Quoted 7 lines
Quoted 5 lines

Remove an unused variable. Note that the pipe obtained there isn't used as well.

I cannot find this commit in wireless-2.6

Strange, git is pulling tricks of some kind. I have the patch in 3 branches of rt2x00.git, master, wireless and upstream. This means it was pulled in from the everything branch on wireless-2.6. So apparently during the rebasing in wireless the patch has disappeared or something. :S

John, can you apply the patch to wireless? Otherwise I'll apply it to rt2x00.git later this week when I rebase everything against the latest wireless git repository (which would remove the old patch from my tree, so I can apply it without conflicts).

Ivo

#6 lore raw
Quoted 4 lines · Ivo van Doorn

Strange, git is pulling tricks of some kind. I have the patch in 3 branches of rt2x00.git, master, wireless and upstream. This means it was pulled in from the everything branch on wireless-2.6. So apparently during the rebasing in wireless the patch has disappeared or something. :S

Yes, that is likely what happened. I'll take care of it.

John

Signature · 2 lines
John W. Linville
[email protected]
#7 lore raw
In reply to Ivo van Doorn
Quoted 6 lines · On Sunday 13 January 2008 20:14:53 Ivo van Doorn wrote:

Hi,

Quoted 2 lines

Remove an unused variable that caused a warning while building. Please note that the pipe obtained there isn't used anywhere else.

This patch is in wireless-2.6 already...

No it is not in wireless-2.6.

Signature · 1 line
Greetings Michael.