Skip to contentSkip to conversation

Missing 'warned = 1' in your latest linux-2.6 commit

PATCH New Hartkopp, Oliver (K-EFE/E) 2 participants 2 messages Jan 14, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Len,

in two cases you just introduce the 'warned' variable but do not set them to '1' after the printk() which is the intetion to print it just one time. Namely in pnpacpi_parse_allocated_ioresource() and pnpacpi_parse_allocated_memresource() the 'warned = 1' is missing.

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi
tdiff;h=66a21736defda339cd93a0e70c1120ab813640f6;hp=2c838197751db19d08a0 0e633e33dce23a69fb0c

Even if it will vanish in 2.6.25 you should fix this new introduced code. :-)

Regards,
Oliver

reviewer
#1 lore raw

PATCH 1/1 pnpacpi: print resource shortage message only once (more)

From: Len Brown <[email protected]>

Wups, previous patch was ineffective in 2 cases.

http://bugzilla.kernel.org/show_bug.cgi?id=9535

---
Thanks for noticing, Oliver!

drivers/pnp/pnpacpi/rsparser.c +2 -0
index f7b8648..6b9840c 100644
@@ -215,6 +215,7 @@ static void pnpacpi_parse_allocated_ioresource(struct pnp_resource_table *res,
 	} else if (!warned) {
 		printk(KERN_ERR "pnpacpi: exceeded the max number of IO "
 				"resources: %d \n", PNP_MAX_PORT);
+		warned = 1;
 	}
 }
 
@@ -242,6 +243,7 @@ static void pnpacpi_parse_allocated_memresource(struct pnp_resource_table *res,
 	} else if (!warned) {
 		printk(KERN_ERR "pnpacpi: exceeded the max number of mem "
 				"resources: %d\n", PNP_MAX_MEM);
+		warned = 1;
 	}
 }