Skip to contentSkip to conversation

remove 11c1:1040 from patch_si3054.c id list

PATCH In review Vasily Khoruzhick 2 participants 2 messages Jan 15, 2008 – Jan 16, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove 11c1:1040 from patch_si3054.c id list

Codec with id 11c1:1040 sitting on hda bus isn't si3054-compatible. It should be removed from patch_si3054.c id list

patch_si3054.c renamed from patch_si3054.c.old +0 -1
@@ -286,7 +286,6 @@
 struct hda_codec_preset snd_hda_preset_si3054[] = {
  	{ .id = 0x163c3055, .name = "Si3054", .patch = patch_si3054 },
  	{ .id = 0x163c3155, .name = "Si3054", .patch = patch_si3054 },
- 	{ .id = 0x11c11040, .name = "Si3054", .patch = patch_si3054 },
  	{ .id = 0x11c13026, .name = "Si3054", .patch = patch_si3054 },
  	{ .id = 0x11c13055, .name = "Si3054", .patch = patch_si3054 },
  	{ .id = 0x11c13155, .name = "Si3054", .patch = patch_si3054 },

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#1 lore raw

At Tue, 15 Jan 2008 20:04:19 +0200,

Quoted 2 lines · Vasily Khoruzhick

Codec with id 11c1:1040 sitting on hda bus isn't si3054-compatible.

Are you 100% sure that it isn't compatible?
It could be a driver bug, or some devices with the same id might work. It might be a mistaken that it's there but might be not.

We need more investigation before doing this.

Takashi