Skip to contentSkip to conversation

b43: Reject new firmware early

PATCH New Michael Buesch 1 participant 1 message Jan 16, 2008 Networking drivers (wireless)

lore
Share & tools
lore

Michael Buesch

author
#0 lore raw

PATCH 1/1 b43: Reject new firmware early

We must reject new incompatible firmware early to avoid running into strange transmission failures.

Signed-off-by Michael Buesch <[email protected]>

---

John, this must _only_ be applied to 2.6.24. 2.6.25 does have actual support for the new firmware.

drivers/net/wireless/b43/main.c +12 -0
Index: wireless-2.6/drivers/net/wireless/b43/main.c
===================================================================
@@ -1800,6 +1800,18 @@ static int b43_upload_microcode(struct b
 		err = -EOPNOTSUPP;
 		goto out;
 	}
+	if (fwrev > 351) {
+		b43err(dev->wl, "YOUR FIRMWARE IS TOO NEW. Please downgrade your "
+		       "firmware.\n");
+		b43err(dev->wl, "Use this firmware tarball: "
+		       "http://downloads.openwrt.org/sources/broadcom-wl-4.80.53.0.tar.bz2\n");
+		b43err(dev->wl, "Use this b43-fwcutter tarball: "
+		       "http://bu3sch.de/b43/fwcutter/b43-fwcutter-009.tar.bz2\n");
+		b43err(dev->wl, "Read, understand and _do_ what this message says, please.\n");
+		b43_write32(dev, B43_MMIO_MACCTL, 0);
+		err = -EOPNOTSUPP;
+		goto out;
+	}
 	b43dbg(dev->wl, "Loading firmware version %u.%u "
 	       "(20%.2i-%.2i-%.2i %.2i:%.2i:%.2i)\n",
 	       fwrev, fwpatch,
Signature · 1 line
Greetings Michael.