Skip to contentSkip to conversation

Hide _OSI warning if osi_linux is enabled

PATCH In review Alex Williamson 2 participants 2 messages Nov 6, 2007 – Jan 17, 2008 ACPI

lore
Share & tools
lore

Alex Williamson

author
#0 lore raw

PATCH 1/1 Hide _OSI warning if osi_linux is enabled

Seems like we don't need to print a big ugly warning when osi_linux
is already properly enabled. Thanks,

Alex

Signed-off-by Alex Williamson <[email protected]>

--

drivers/acpi/osl.c +3 -2
diff -r c7f1be4e5832 drivers/acpi/osl.c
@@ -1167,14 +1167,15 @@ acpi_os_validate_interface (char *interf
 	if (!strncmp(osi_additional_string, interface, OSI_STRING_LENGTH_MAX))
 		return AE_OK;
 	if (!strcmp("Linux", interface)) {
+		if (osi_linux)
+			return AE_OK;
+
 		printk(KERN_WARNING PREFIX
 			"System BIOS is requesting _OSI(Linux)\n");
 		printk(KERN_WARNING PREFIX
 			"If \"acpi_osi=Linux\" works better,\n"
 			"Please send dmidecode "
 			"to [email protected]\n");
-		if(osi_linux)
-			return AE_OK;
 	}
 	return AE_SUPPORT;
 }
reviewer
#1 lore raw
Quoted 3 lines · Alex Williamson

Seems like we don't need to print a big ugly warning when osi_linux
is already properly enabled. Thanks,

True if "properly enabled" were not an oxymoron:-) i need to hack on this code a bit so that it doesn't complain when DMI or the user enabled it, but otherwise does.

thanks,
-Len

Quoted 28 lines

Alex

Signed-off-by Alex Williamson <[email protected]>

--

diff -r c7f1be4e5832 drivers/acpi/osl.c

drivers/acpi/osl.c +3 -2
@@ -1167,14 +1167,15 @@ acpi_os_validate_interface (char *interf
 	if (!strncmp(osi_additional_string, interface, OSI_STRING_LENGTH_MAX))
 		return AE_OK;
 	if (!strcmp("Linux", interface)) {
+		if (osi_linux)
+			return AE_OK;
+
 		printk(KERN_WARNING PREFIX
 			"System BIOS is requesting _OSI(Linux)\n");
 		printk(KERN_WARNING PREFIX
 			"If \"acpi_osi=Linux\" works better,\n"
 			"Please send dmidecode "
 			"to [email protected]\n");
-		if(osi_linux)
-			return AE_OK;
 	}
 	return AE_SUPPORT;
 }