getdelays: fix gcc warnings
PATCH 1/1 getdelays: fix gcc warnings
From: Randy Dunlap <[email protected]>
Fix gcc warnings in getdelays.c:
Documentation/accounting/getdelays.c: In function 'task_context_switch_counts':Documentation/accounting/getdelays.c:214: warning: format '%15lu' expects type 'long unsigned int', but argument 4 has type '__u64' Documentation/accounting/getdelays.c:214: warning: format '%15lu' expects type 'long unsigned int', but argument 5 has type '__u64' Documentation/accounting/getdelays.c: In function 'main':Documentation/accounting/getdelays.c:402: warning: format '%d' expects type 'int', but argument 2 has type 'long unsigned int' Documentation/accounting/getdelays.c: In function 'get_family_id':Documentation/accounting/getdelays.c:171: warning: 'id' may be used uninitialized in this function
One warning is not a problem and can be dismissed:Documentation/accounting/getdelays.c: In function 'main':Documentation/accounting/getdelays.c:236: warning: 'cmd_type' may be used uninitialized in this function
--- Documentation/accounting/getdelays.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/accounting/getdelays.c +3 -3
@@ -168,7 +168,7 @@ int get_family_id(int sd)char buf[256 ]; } ans; -int id, rc; +int id =0 , rc;struct nlattr *na;int rep_len;
@@ -209,7 +209,7 @@ void print_delayacct(struct taskstats *tvoid task_context_switch_counts (struct taskstats *t) {printf ("\n\nTask %15s%15s\n" -" %15lu%15lu\n" , +" %15llu%15llu\n" ,"voluntary" ,"nonvoluntary" , t->nvcsw, t->nivcsw); }
@@ -399,7 +399,7 @@ int main(int argc, char *argv[]) goto done; } -PRINTF ("nlmsghdr size=%d, nlmsg_len=%d, rep_len=%d\n" , +PRINTF ("nlmsghdr size=%zu, nlmsg_len=%d, rep_len=%d\n" ,sizeof (struct nlmsghdr ), msg.n.nlmsg_len, rep_len);
Quoted 3 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Fix gcc warnings in
getdelays.c:
Hi, Randy,
Thanks for finding these problems and fixing them. The fixes look quite straight forward.
Signature · 4 lines
Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL