Skip to contentSkip to conversation

UML - Fix infinite mconsole loop

PATCH New Jeff Dike 1 participant 1 message Jan 17, 2008 User-mode Linux (UML)

lore
Share & tools
lore

Jeff Dike

author
#0 lore raw

PATCH 15/20 UML - Fix infinite mconsole loop

From: Karol Swietlicki <[email protected]>

This patch takes care of a problem with the stopping code.

The function inside the while condition returns 0 to signify a problem. A problem could be for example a bad command or a bad version of the mconsole client.
A bad command would terminate the stopping loop and resume the kernel. This is a problem.

A better solution is to make the loop infinite and don't leave it until we are explicitly told to.

---
 arch/um/drivers/mconsole_kern.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/um/drivers/mconsole_kern.c +3 -1
Index: linux-2.6.22/arch/um/drivers/mconsole_kern.c
===================================================================
@@ -305,7 +305,9 @@ void mconsole_stop(struct mc_request *re
 	deactivate_fd(req->originating_fd, MCONSOLE_IRQ);
 	os_set_fd_block(req->originating_fd, 1);
 	mconsole_reply(req, "stopped", 0, 0);
-	while (mconsole_get_request(req->originating_fd, req)) {
+	for (;;) {
+		if (!mconsole_get_request(req->originating_fd, req))
+			continue;
 		if (req->cmd->handler == mconsole_go)
 			break;
 		if (req->cmd->handler == mconsole_stop) {

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel