export getledstate()
PATCH 1/1 export getledstate()
I write adapters for disabled people, and we often have to do specialized functions based on keystrokes and key chords.
I would like to do certain things when keys are hit and num lock is on, but there is no easy way to get the led state.
There is a nice function getledstate()
in keyboard.c, it just isn't exported.
Here is the patch that would do that.
Can you apply this patch, or, is there another easy way to get this information, or, would it be better to fold this information into keyboard_notifier_param, along with shift state etc.
I use notifiers, so this would be natural, and almost as easy.
I'd be happy to write that patch, if you think that would be a superior design.
char/keyboard.c.new renamed from char/keyboard.c +1 -0
@@ -963,6 +963,7 @@ unsigned char getledstate(void) { return ledstate; } +EXPORT_SYMBOL_GPL(getledstate); void setledstate(struct kbd_struct *kbd, unsigned int led) {
Thanks.
Karl Dahlke
Quoted 4 lines · On Tue, 19 Feb 2008 13:57:23 -0500 Karl Dahlke wrote:
I write adapters for disabled people, and we often have to do specialized functions based on keystrokes and key chords.
I would like to do certain things when keys are hit and num lock is on, but there is no easy way to get the led state.
Quoted 8 lines
There is a nice function
getledstate()
inkeyboard.c, it just isn't exported.
Here is the patch that would do that.
Can you apply this patch, or, is there another easy way to get this information, or, would it be better to fold this information intokeyboard_notifier_param, along with shift state etc.
I use notifiers, so this would be natural, and almost as easy.
I'd be happy to write that patch, if you think that would be a superior design.
cc Dmitry added.
I don't oppose the export, but it seems that using getledstate() asynchronously could return out-of-sync info, while adding this info to the notifier data would synchronize the info..
Maybe it depends on how it's done.
char/keyboard.c.new
Quoted 3 lines
char/keyboard.c.new renamed from char/keyboard.c +0
-0
--- linux/drivers/char/keyboard.c.old
+++ linux/drivers/char/keyboard.c
is the preferred form. (a) keep the top-level linux dir name.
(b) the +++ line has the correct file name.
char/keyboard.c.new unsigned char getledstate(void) · line 969
Quoted 8 lines
char/keyboard.c.new renamed from char/keyboard.c +1
-0@@ -963,6 +963,7 @@ unsigned char getledstate(void) { return ledstate; } +EXPORT_SYMBOL_GPL(getledstate); void setledstate(struct kbd_struct *kbd, unsigned int led) {
---
~Randy