Skip to contentSkip to conversation

ACPI early ioremap problems

DISCUSSION Ingo Molnar 2 participants 7 messages Jan 19, 2008 – Jan 21, 2008 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

(Cc:-ing to lkml, because this might interest others too)

Quoted 6 lines · Andi Kleen
Quoted 3 lines

would be interesting to figure out what's going on here - i doubt it's an ACPI bug, because then we'd be getting a hard page fault, right? In

ACPI hasn't changed at all in git-x86 and it worked fine before. So I don't really blame it.

yes, it did not change, but there are latent ACPI bugs/uncleanlinesses where it references an already unmapped table. This worked by chance until now, because we didnt actually unmap any tables - but now we explicitly map/unmap the tables via the MMU. But, i dont think that's the cause of the failure here - those bugs typically show up in other ways.

Quoted 8 lines
Quoted 4 lines

that case it's a 64-bit early_ioremap() bug that we want to find even if ACPI didnt use early_ioremap().

and this all runs before zap_low_mappings(), right?

No after. Since some time x86-64 does the equivalent of z_l_m() in head64(); this means before start_kernel and definitely before setup_arch which sets up ACPI.

that would mean early_ioremap() should switch to ioremap() after that point. Could you try that, does it resolve the failure you are seeing?

Long-term we want to have a single, uniform ioremap() interface (on 32-bit and 64-bit x86 as well) that can be used anytime, which just switches to the right lowlevel method depending on how far we are into the pagetable and memory subsystem bootstrap - instead of these more fragile "can we now use early_ioremap() or should we already be using ioremap()" usages.

Ingo

#4 lore raw
Quoted 11 lines · Ingo Molnar
Quoted 8 lines
Quoted 4 lines

that case it's a 64-bit early_ioremap() bug that we want to find even if ACPI didnt use early_ioremap().

and this all runs before zap_low_mappings(), right?

No after. Since some time x86-64 does the equivalent of z_l_m() in head64(); this means before start_kernel and definitely before setup_arch which sets up ACPI.

that would mean early_ioremap() should switch to ioremap() after that point. Could you try that, does it resolve the failure you are seeing?

ioremap() does alloc_page and that won't work before paging_init(). Early ACPI scan is before paging_init() because paging_init() needs node discovery at at least; which requires some ACPI tables.

Quoted 6 lines

Long-term we want to have a single, uniform ioremap() interface (on 32-bit and 64-bit x86 as well) that can be used anytime, which just switches to the right lowlevel method depending on how far we are into the pagetable and memory subsystem bootstrap - instead of these more fragile "can we now use early_ioremap() or should we already be using ioremap()" usages.

I didn't think there were enough early/bt_ioremap() users for this to be really worthwhile. The only code that does both I'm aware of is the memory setup code.

-Andi

#5 lore raw
Quoted 10 lines · Andi Kleen
Quoted 9 lines · Ingo Molnar
Quoted 8 lines
Quoted 4 lines

that case it's a 64-bit early_ioremap() bug that we want to find even if ACPI didnt use early_ioremap().

and this all runs before zap_low_mappings(), right?

No after. Since some time x86-64 does the equivalent of z_l_m() in head64(); this means before start_kernel and definitely before setup_arch which sets up ACPI.

Quoted 6 lines
Quoted 2 lines

that would mean early_ioremap() should switch to ioremap() after that point. Could you try that, does it resolve the failure you are seeing?

ioremap() does alloc_page and that won't work before paging_init(). Early ACPI scan is before paging_init() because paging_init() needs node discovery at at least; which requires some ACPI tables.

hm, so are you saying that on 64-bit there's in essence no usable ioremap facility between zap_low_mappings() and paging_init()? (early_ioremap() is not usable anymore, and ioremap() is not yet usable.) I guess we'll have to pick up the 32-bit early_ioremap() code for 64-bit as well.

Ingo

#6 lore raw
Quoted 5 lines

hm, so are you saying that on 64-bit there's in essence no usable ioremap facility between zap_low_mappings() and paging_init()? (early_ioremap() is not usable anymore, and ioremap() is not yet usable.) I guess we'll have to pick up the 32-bit early_ioremap() code for 64-bit as well.

No early_ioremap() should work. Or rather used to work.

It does map into the kernel mapping which is not zapped. It just broke recently.

But it definitely used to work because several users used it before paging_init() even before the recent PAT changes.

-Andi

#7 lore raw

Re: ACPI early ioremap problems II

As a followup I see this problem on three different 64bit machines now. Symptom is usually that only one core is active because ACPI doesn't see the other processors in its tables.

-Andi

#8 lore raw

Re: ACPI early ioremap problems II

Quoted 3 lines · Andi Kleen

As a followup I see this problem on three different 64bit machines now. Symptom is usually that only one core is active because ACPI doesn't see the other processors in its tables.

to be able to have a chance to fix it we need you meet the minimum threshold for bugreports: please send the failing .config and a full boot message of the incident as well. (Please also check latest x86.git, maybe it's something that got fixed today.)

I have tested latest x86.git#mm on 3 different 64bit machines and Thomas tested it too, and none of us saw any crashes. So whatever you are seeing, it's unfortunately not very common to trigger.

Ingo

#9 lore raw

Re: ACPI early ioremap problems II

Quoted 11 lines · Ingo Molnar
Quoted 3 lines · Andi Kleen

As a followup I see this problem on three different 64bit machines now. Symptom is usually that only one core is active because ACPI doesn't see the other processors in its tables.

to be able to have a chance to fix it we need you meet the minimum threshold for bugreports: please send the failing .config and a full boot message of the incident as well. (Please also check latest x86.git, maybe it's something that got fixed today.)

The other crash seems to have gone away on git tip 28a0fcd6b38e247200bd857996375aee91eae8ce now. I also don't see the missing nodes or missing cores anymore. Also the extended memory on AMD seems to be detected correctly gain.

Thanks,

-Andi