Skip to contentSkip to conversation

sensors-detect: Small W83627EHF comment fix

PATCH In review Uwe Hermann 2 participants 4 messages Jan 18, 2008 – Jan 26, 2008

lore
Share & tools
lore

Uwe Hermann

author
#0 lore raw

PATCH 1/1 sensors-detect: Small W83627EHF comment fix

Hi,

here's a tiny patch to update a comment in sensors-detect. I can confirm there are boards with Winbond W83627EHF with the ID 0x8854, in my case the ASUS A8V-E Deluxe.

See also
http://www.coreboot.org/pipermail/coreboot/2008-January/029416.html

Pretty trivial, not sure if this is worth committing, just wanted to let you know.

Signed-off-by Uwe Hermann <[email protected]>

Index: prog/detect/sensors-detect
=================================--- prog/detect/sensors-detect (Revision 5106)
+++ prog/detect/sensors-detect (Arbeitskopie)
@@ -2010,7 +2010,7 @@

       {

name => "Winbond W83627EHF/EF/EHG/EG Super IO Sensors", driver => "w83627ehf",
- # W83627EHF datasheet says 0x886x but 0x8853 was seen, thus the
+ # W83627EHF datasheet says 0x886x but 0x885[34] was seen, thus the

 	# broader mask. W83627EHG was seen with ID 0x8863.
 	devid => 0x8840,
 	devid_mask => 0xFFC0,

Cheers, Uwe.

Signature · 7 lines
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#1 lore raw

Hi Uwe,

Quoted 17 lines · Uwe Hermann

here's a tiny patch to update a comment in sensors-detect. I can confirm there are boards with Winbond W83627EHF with the ID 0x8854, in my case the ASUS A8V-E Deluxe.

See also
http://www.coreboot.org/pipermail/coreboot/2008-January/029416.html

Pretty trivial, not sure if this is worth committing, just wanted to let you know.

Signed-off-by Uwe Hermann <[email protected]>

Index: prog/detect/sensors-detect
=================================> --- prog/detect/sensors-detect (Revision 5106)
+++ prog/detect/sensors-detect (Arbeitskopie)

Review line 2016

Quoted 8 lines
(quoted diff) +1 -1
@@ -2010,7 +2010,7 @@
       {
 	name => "Winbond W83627EHF/EF/EHG/EG Super IO Sensors",
 	driver => "w83627ehf",
-	# W83627EHF datasheet says 0x886x but 0x8853 was seen, thus the
+	# W83627EHF datasheet says 0x886x but 0x885[34] was seen, thus the
 	# broader mask. W83627EHG was seen with ID 0x8863.
 	devid => 0x8840,
 	devid_mask => 0xFFC0,

We can probably go even further. The w83627ehf driver says that 0x885x corresponds to the W83627EHF and 0x886x corresponds to the W83627EHG. While the datasheet doesn't mention anything like this, it seems to be correct on all chips I (and others) have checked. For example my W83627EHG has ID 0x8868.

So we could have 2 entries in sensors-detect, one for the W83627EHF/EF and one for the W83627EHG/EG. It would be more precise, and it also has the advantage that the mask(s) would be narrower. What do you think?

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
author
#2 lore raw
In reply to Uwe Hermann

Hi,

Quoted 9 lines · Jean Delvare

We can probably go even further. The w83627ehf driver says that 0x885x corresponds to the W83627EHF and 0x886x corresponds to the W83627EHG. While the datasheet doesn't mention anything like this, it seems to be correct on all chips I (and others) have checked. For example my W83627EHG has ID 0x8868.

So we could have 2 entries in sensors-detect, one for the W83627EHF/EF and one for the W83627EHG/EG. It would be more precise, and it also has the advantage that the mask(s) would be narrower. What do you think?

Yeah, why not. We cannot be 100% sure, but it sounds like a reasonable assumption. But I'd add a comment in the script which says that this is just an educated guess.

Uwe.

Signature · 7 lines
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#3 lore raw
In reply to Uwe Hermann
Quoted 7 lines · Uwe Hermann
Quoted 6 lines · Jean Delvare

We can probably go even further. The w83627ehf driver says that 0x885x corresponds to the W83627EHF and 0x886x corresponds to the W83627EHG. While the datasheet doesn't mention anything like this, it seems to be correct on all chips I (and others) have checked. For example my W83627EHG has ID 0x8868.

Quoted 7 lines
Quoted 3 lines

So we could have 2 entries in sensors-detect, one for the W83627EHF/EF and one for the W83627EHG/EG. It would be more precise, and it also has the advantage that the mask(s) would be narrower. What do you think?

Yeah, why not. We cannot be 100% sure, but it sounds like a reasonable assumption. But I'd add a comment in the script which says that this is just an educated guess.

OK. Can you please send a patch doing this?

Thanks,

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors