small problem w/ new xfs defaults patch
growfs/xfs_growfs.c +1 -2
@@ -58,7 +58,6 @@ report_info(int isint, char *logname, char *rtname, - int unwritten, int lazycount, int dirversion, int logversion,
@@ -68,7 +67,7 @@ report_info("meta-data=%-22s isize=%-6u agcount=%u, agsize=%u blks\n" " =%-22s sectsz=%-5u attr=%u\n" "data =%-22s bsize=%-6u blocks=%llu, imaxpct=%u\n" -" =%-22s sunit=%-6u swidth=%u blks, unwritten=%u\n" +" =%-22s sunit=%-6u swidth=%u blks" "naming =version %-14u bsize=%-6u\n" "log =%-22s bsize=%-6u blocks=%u, version=%u\n" " =%-22s sectsz=%-5u sunit=%u blks, lazy-count=%u\n"
couple things... you lost a "\n" off the end of the data section there...
Also, do you really want to drop reporting of unwritten extents? Even if you're disallowing the selection on new mkfs's there may still be different flavors of filesystems in existence, should it still be reported?
-Eric
Quoted 2 lines · Eric Sandeen
Index:
xfsprogs-2.9.4/growfs/xfs_growfs.c
===================================================================
[...]
Quoted 1 line
couple things... you lost a "\n" off the end of the data section there...
That has been fixed, I guess it needs to be sent to oss (barry?)
Quoted 3 lines
Also, do you really want to drop reporting of unwritten extents? Even if you're disallowing the selection on new mkfs's there may still be different flavors of filesystems in existence, should it still be reported?
I don't really care, whatever the oss/xfs-master people like best.
Cheers
Signature · 1 line
Niv
Quoted 8 lines · Niv Sardi
Quoted 2 lines · Eric Sandeen
Index:
xfsprogs-2.9.4/growfs/xfs_growfs.c
===================================================================[...]
Quoted 1 line
couple things... you lost a "\n" off the end of the data section there...
That has been fixed, I guess it needs to be sent to oss (barry?)
Ok, see that. Sorry... grabbed the original patch and didn't check cvs for updates.
Thanks,
-Eric
Quoted 7 lines
Quoted 3 lines
Also, do you really want to drop reporting of unwritten extents? Even if you're disallowing the selection on new mkfs's there may still be different flavors of filesystems in existence, should it still be reported?
I don't really care, whatever the oss/xfs-master people like best.
Cheers
Quoted 9 lines · Niv Sardi
Quoted 2 lines · Eric Sandeen
Index:
xfsprogs-2.9.4/growfs/xfs_growfs.c
===================================================================[...]
Quoted 1 line
couple things... you lost a "\n" off the end of the data section there...
That has been fixed, I guess it needs to be sent to oss (barry?)
Quoted 7 lines
Quoted 3 lines
Also, do you really want to drop reporting of unwritten extents? Even if you're disallowing the selection on new mkfs's there may still be different flavors of filesystems in existence, should it still be reported?
I don't really care, whatever the oss/xfs-master people like best.
Cheers
My preference would be to report the unwritten extent flag as Eric suggested.
--Tim