Skip to contentSkip to conversation

gfs2 umount: support fake -r option

PATCH New Fabio M. Di Nitto 2 participants 2 messages Jan 19, 2008 – Jan 21, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gfs2 umount: support fake -r option

Hi guys,

in certain situations where gfs2 init scripts are not used to umount gfs2 volume, we endup with umount.gfs2 being invoked with -r option and this fails because we don't know what to do with this option.

The patch simply ack the option and ignores it for now allowing a reboot process to keep going.

Please ACK or apply.

Fabio

Index: umount.gfs2.c
===================================================================
RCS file: /cvs/cluster/cluster/gfs2/mount/umount.gfs2.c,v retrieving revision 1.15

umount.gfs2.c +4 -1
diff -u -r1.15 umount.gfs2.c
@@ -52,7 +52,7 @@
  	/* FIXME: check for "quiet" option and don't print in that case */
 
  	while (cont) {
-		optchar = getopt(argc, argv, "fhVvX:");
+		optchar = getopt(argc, argv, "fhVvX:r");
 
  		switch (optchar) {
  		case EOF:
@@ -79,6 +79,9 @@
  			print_version();
  			exit(EXIT_SUCCESS);
 
+		case 'r':
+			break; /* used by umount to remount ro if umount fails */
+
  		default:
  			break;
  		}

--
I'm going to make him an offer he can't refuse.

#1 lore raw

PATCH 1/1 gfs2 umount: support fake -r option

Quoted 11 lines · Fabio M. Di Nitto

Hi guys,

in certain situations where gfs2 init scripts are not used to umount gfs2 volume, we endup with umount.gfs2 being invoked with -r option and this fails because we don't know what to do with this option.

The patch simply ack the option and ignores it for now allowing a reboot process to keep going.

Please ACK or apply.

ack