Skip to contentSkip to conversation

add module taint on ndiswrapper

PATCH Applied Jon Masters 2 participants 2 messages Jan 21, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add module taint on ndiswrapper

The struct module taints member is supposed to store per-module taint data. The kernel knows about certain specific external modules that will taint the kernel, such as ndiswrapper. Use of ndiswrapper possibly should set the per-module taint in addition to the global kernel taint flag, unless we're arguing not because wrapper module itself is not what actually causes the kernel to be tainted as such?

kernel/module.c +1 -1
diff -urp linus_26/kernel/module.c jcm_26/kernel/module.c
@@ -1893,7 +1893,7 @@ static struct module *load_module(void _
 	set_license(mod, get_modinfo(sechdrs, infoindex, "license"));
 
 	if (strcmp(mod->name, "ndiswrapper") == 0)
-		add_taint(TAINT_PROPRIETARY_MODULE);
+		add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
 	if (strcmp(mod->name, "driverloader") == 0)
 		add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
 
#1 lore raw
Quoted 8 lines · On Tuesday 22 January 2008 07:43:41 Jon Masters wrote:

The struct module taints member is supposed to store per-module taint data. The kernel knows about certain specific external modules that will taint the kernel, such as ndiswrapper. Use of ndiswrapper possibly should set the per-module taint in addition to the global kernel taint flag, unless we're arguing not because wrapper module itself is not what actually causes the kernel to be tainted as such?

Thanks, applied.

Rusty.