Skip to contentSkip to conversation

usb: ohci-sm501 driver V2

PATCH In review Magnus Damm 3 participants 6 messages Jan 23, 2008 – Jan 28, 2008

Subsystems (3)
USB SuperH USB ohci driver
lore
Share & tools
lore

Magnus Damm

author
#0 lore raw

PATCH 2/2 usb: ohci-sm501 driver V2

usb: ohci-sm501 driver V2

This patch adds sm501 ohci support. It's all very straightforward with the exception of dma_declare_coherent_memory() and HCD_LOCAL_MEM. Together they are used to ensure that usb data is allocated using dma_alloc_coherent(), and that only valid dma memory is used to allocate from. This driver is a platform device, and the mfd driver sm501.c is already creating one usb host controller instance per sm501.

Signed-off-by Magnus Damm <[email protected]>

---

 drivers/usb/host/ohci-hcd.c   |    5 
 drivers/usb/host/ohci-sm501.c |  264 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 269 insertions(+)
drivers/usb/host/ohci-hcd.c +5 -0
@@ -1048,6 +1048,11 @@ MODULE_LICENSE ("GPL");
 #define SSB_OHCI_DRIVER		ssb_ohci_driver
 #endif
 
+#ifdef CONFIG_MFD_SM501
+#include "ohci-sm501.c"
+#define PLATFORM_DRIVER		ohci_hcd_sm501_driver
+#endif
+
 #if	!defined(PCI_DRIVER) &&		\
 	!defined(PLATFORM_DRIVER) &&	\
 	!defined(OF_PLATFORM_DRIVER) &&	\
drivers/usb/host/ohci-sm501.c new file +264 -0

264 lines not on this page · raw message

#1 lore raw
Quoted 1 line · Magnus Damm

+        * regular memory. The HCD_BOUNCE flag does just that.

ACK other than this comment... flag has been renamed.

#2 lore raw
In reply to Magnus Damm
Quoted 4 lines · David Brownell
Quoted 1 line · Magnus Damm

+??????? * regular memory. The HCD_BOUNCE flag does just that.

ACK other than this comment... flag has been renamed.

Renamed to what? I can easily edit the diff...

thanks,

greg k-h

#3 lore raw
In reply to Magnus Damm
Quoted 7 lines · Greg KH
Quoted 4 lines · David Brownell
Quoted 1 line · Magnus Damm

+??????? * regular memory. The HCD_BOUNCE flag does just that.

ACK other than this comment... flag has been renamed.

Renamed to what? I can easily edit the diff...

HCD_LOCAL_MEM, as I recall (the patch 1/2 in this group).

author
#4 lore raw
In reply to Magnus Damm
Quoted 11 lines · David Brownell
Quoted 7 lines · Greg KH
Quoted 4 lines · David Brownell
Quoted 1 line · Magnus Damm

+??????? * regular memory. The HCD_BOUNCE flag does just that.

ACK other than this comment... flag has been renamed.

Renamed to what? I can easily edit the diff...

HCD_LOCAL_MEM, as I recall (the patch 1/2 in this group).

Yes, correct. Sorry about that.

Greg, please edit the diff if possible.

Thank you.

/ magnus

#5 lore raw
In reply to Magnus Damm
Quoted 9 lines · Magnus Damm
Quoted 8 lines · David Brownell
Quoted 6 lines · Greg KH
Quoted 4 lines · David Brownell
Quoted 1 line · Magnus Damm

+??????? * regular memory. The HCD_BOUNCE flag does just that.

ACK other than this comment... flag has been renamed.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Renamed to what? I can easily edit the diff...

HCD_LOCAL_MEM, as I recall (the patch 1/2 in this group).

Yes, correct. Sorry about that.

Greg, please edit the diff if possible.

Now edited.

thanks,

greg k-h