Skip to contentSkip to conversation

usb/caiaq: decrease period_bytes_min

PATCH Applied Daniel Mack 2 participants 3 messages Jan 24, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb/caiaq: decrease period_bytes_min

This patch increases the snd_pcm_hardware->period_bytes_min field in the caiaq/usb audio driver. The hardware can actually handle as few as 128 bytes, depending on the system. So it makes no sense to keep applications from actually using such values.

sound/usb/caiaq/caiaq-audio.c +1 -1
index 2f9e9b2..9cc4cd8 100644
@@ -57,7 +57,7 @@ static struct snd_pcm_hardware snd_usb_caiaq_pcm_hardware = {
 	.channels_min	= CHANNELS_PER_STREAM,
 	.channels_max	= CHANNELS_PER_STREAM,
 	.buffer_bytes_max = MAX_BUFFER_SIZE,
-	.period_bytes_min = 4096,
+	.period_bytes_min = 128,
 	.period_bytes_max = MAX_BUFFER_SIZE,
 	.periods_min	= 1,
 	.periods_max	= 1024,
sound/usb/caiaq/caiaq-device.c +1 -1
index 5cd92ae..58d25e4 100644
@@ -42,7 +42,7 @@
 #endif
 
 MODULE_AUTHOR("Daniel Mack <[email protected]>");
-MODULE_DESCRIPTION("caiaq USB audio, version 1.3.1");
+MODULE_DESCRIPTION("caiaq USB audio, version 1.3.2");
 MODULE_LICENSE("GPL");
 MODULE_SUPPORTED_DEVICE("{{Native Instruments, RigKontrol2},"
 			 "{Native Instruments, RigKontrol3},"

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Applied
#1 lore raw

At Thu, 24 Jan 2008 18:44:07 +0100,

Quoted 2 lines · Daniel Mack

This patch increases the snd_pcm_hardware->period_bytes_min field in the

decrease, right? :)

Quoted 5 lines

caiaq/usb audio driver. The hardware can actually handle as few as 128 bytes, depending on the system. So it makes no sense to keep applications from actually using such values.

Applied to HG tree. Thanks.

Takashi

#2 lore raw
Quoted 3 lines · Takashi Iwai
Quoted 1 line

This patch increases the snd_pcm_hardware->period_bytes_min field in the

decrease, right? :)

On closer examination, 128 is actually less than 4096, yes. Except for very large values of 128. ;)

Daniel