Skip to contentSkip to conversation

unifdef linux/vt.h

PATCH In review Olaf Hering 3 participants 7 messages Jan 25, 2008 – Feb 10, 2008

lore
Share & tools
lore

Olaf Hering

author
#0 lore raw

PATCH 1/1 unifdef linux/vt.h

remove the newly added __KERNEL__ block from linux/vt.h

Signed-off-by Olaf Hering <[email protected]>
---
 include/linux/Kbuild |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/Kbuild +1 -1
@@ -157,7 +157,6 @@ header-y += veth.h
 header-y += video_decoder.h
 header-y += video_encoder.h
 header-y += videotext.h
-header-y += vt.h
 header-y += x25.h
 
 unifdef-y += acct.h

@@ -348,6 +347,7 @@ unifdef-y += videodev.h
 unifdef-y += virtio_config.h
 unifdef-y += virtio_blk.h
 unifdef-y += virtio_net.h
+unifdef-y += vt.h
 unifdef-y += wait.h
 unifdef-y += wanrouter.h
 unifdef-y += watchdog.h
author
#1 lore raw

PATCH 1/1 hide kernel only code in linux/jbd.h

Move a few kernel only stuff into __KERNEL__

Signed-off-by Olaf Hering <[email protected]>
---
 include/linux/jbd.h |    2 --
 1 file changed, 2 deletions(-)
include/linux/jbd.h +0 -2
@@ -33,7 +33,6 @@
 #include <linux/lockdep.h>
 
 #include <asm/semaphore.h>
-#endif
 
 #define journal_oom_retry 1
 

@@ -84,7 +83,6 @@ static inline void jbd_free(void *ptr, s
 
 #define JFS_MIN_JOURNAL_BLOCKS 1024
 
-#ifdef __KERNEL__
 
 /**
  * typedef handle_t - The handle_t type represents a single atomic update being performed by some process.
author
#3 lore raw
Quoted 9 lines · Christoph Hellwig
Quoted 4 lines · Olaf Hering

remove the newly added __KERNEL__ block from linux/vt.h

Signed-off-by Olaf Hering <[email protected]>

We shouldn't add more unifdef-y headers. Please move the newly-added kernel-only section to a different file instead and beat up the person who introduced it with a big cluestick.

Suggest a place, please.

Also, I think every header should go throug unifdef.

author
#4 lore raw
In reply to Olaf Hering
Quoted 1 line · Olaf Hering

remove the newly added __KERNEL__ block from linux/vt.h

Can you pick this up? The patch cant get any better.

Quoted 18 lines
include/linux/Kbuild +1 -1
@@ -157,7 +157,6 @@ header-y += veth.h
 header-y += video_decoder.h
 header-y += video_encoder.h
 header-y += videotext.h
-header-y += vt.h
 header-y += x25.h
 
 unifdef-y += acct.h

@@ -348,6 +347,7 @@ unifdef-y += videodev.h
 unifdef-y += virtio_config.h
 unifdef-y += virtio_blk.h
 unifdef-y += virtio_net.h
+unifdef-y += vt.h
 unifdef-y += wait.h
 unifdef-y += wanrouter.h
 unifdef-y += watchdog.h
#5 lore raw
Quoted 5 lines · On Fri, 8 Feb 2008 18:38:10 +0100 Olaf Hering <[email protected]> wrote:
Quoted 1 line · Olaf Hering

remove the newly added __KERNEL__ block from linux/vt.h

Can you pick this up? The patch cant get any better.

spose so. Coud you send a tested version against current mainline please?

author
#6 lore raw
Quoted 10 lines · Andrew Morton
Quoted 5 lines · On Fri, 8 Feb 2008 18:38:10 +0100 Olaf Hering <[email protected]> wrote:
Quoted 1 line · Olaf Hering

remove the newly added __KERNEL__ block from linux/vt.h

Can you pick this up? The patch cant get any better.

spose so. Coud you send a tested version against current mainline please?

Its already fixed.

commit 7998a731664ac4988b349e70669bac11e3b3a3ac
Author: Robert P. J. Day <[email protected]>
Date: Mon Dec 31 14:58:38 2007 +0100

A few corrections to include/linux/Kbuild

auxvec.h, i2c-dev.h and vt.h *should* be unifdef'ed i2o-dev.h does not need unifdef'ing

Signed-off-by Robert P. J. Day <[email protected]>
Cc David Woodhouse <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
Signed-off-by Sam Ravnborg <[email protected]>