Skip to contentSkip to conversation

aic79xx: fix sense_buffer access bug

PATCH FUJITA Tomonori 2 participants 2 messages Jan 27, 2008 – Jan 29, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Ah, I overlooked more LLDs...

=
From: FUJITA Tomonori <[email protected]>
Subject: [PATCH] aic79xx: fix sense_buffer access bug

The commit de25deb18016f66dcdede165d07654559bb332bc changed scsi_cmnd.sense_buffer from a static array to a dynamically allocated buffer. We can't access to sense_buffer in '&cmd->sense_buffer' way.

---
 drivers/scsi/aic7xxx/aic79xx_osm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/aic7xxx/aic79xx_osm.c +1 -1
index 0e4708f..3c4efa4 100644
@@ -1922,7 +1922,7 @@ ahd_linux_queue_cmd_complete(struct ahd_softc *ahd, struct scsi_cmnd *cmd)
 				struct scsi_sense_data *sense;
 				
 				sense = (struct scsi_sense_data *)
-					&cmd->sense_buffer;
+					cmd->sense_buffer;
 				if (sense->extra_len >= 5 &&
 				    (sense->add_sense_code == 0x47
 				     || sense->add_sense_code == 0x48))
Signature · 1 line
1.5.3.4
#1 lore raw
Quoted 11 lines · FUJITA Tomonori

Ah, I overlooked more LLDs...

=
From: FUJITA Tomonori <[email protected]>
Subject: [PATCH] aic79xx: fix sense_buffer access bug

The commit de25deb18016f66dcdede165d07654559bb332bc changed scsi_cmnd.sense_buffer from a static array to a dynamically allocated buffer. We can't access to sense_buffer in '&cmd->sense_buffer' way.

Cheers,

Hannes

Signature · 8 lines
Dr. Hannes Reinecke		      zSeries & Storage
[email protected]			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html