Skip to contentSkip to conversation

Pull request: DMA pool updates

DISCUSSION Matthew Wilcox 3 participants 5 messages Jan 29, 2008 – Feb 4, 2008 Memory management

lore
Share & tools
lore
#0 lore raw

G'day Linus, mate

Could you pull the dmapool branch of
git://git.kernel.org/pub/scm/linux/kernel/git/willy/misc.git please?

All the patches have been posted to linux-kernel before, and various comments (and acks) have been taken into account.

It's a fairly nice performance improvement, so would be good to get in. It's survived a few hours of *mumble* high-stress database benchmark, so I have high confidence in its stability.

Signature · 10 lines
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
maintainer
#1 lore raw
Quoted 5 lines · On Mon, 28 Jan 2008 17:11:47 -0700 Matthew Wilcox <[email protected]> wrote:

G'day Linus, mate

Could you pull the dmapool branch of
git://git.kernel.org/pub/scm/linux/kernel/git/willy/misc.git please?

The usual form is, I believe,

git://git.kernel.org/pub/scm/linux/kernel/git/willy/misc.git dmapool

Otherwise people get all confused and think it's an empty tree (like I just did).

Quoted 6 lines

All the patches have been posted to linux-kernel before, and various comments (and acks) have been taken into account.

It's a fairly nice performance improvement, so would be good to get in. It's survived a few hours of *mumble* high-stress database benchmark, so I have high confidence in its stability.

Could we please at least have a shortlog so we can find out what the patch titles are so we can google them so we can find out what the heck you're proposing we add to the kernel?

<does a pull, goes on an archive hunt>

It shouldn't be this hard!

There were no replies to v2 of the patch series. It all looks reasonable from a quick scan (assuming the patches are unchanged since then).

afaik these patches have been tested by nobody except thyself?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#2 lore raw
Quoted 6 lines · Andrew Morton

The usual form is, I believe,

git://git.kernel.org/pub/scm/linux/kernel/git/willy/misc.git dmapool

Otherwise people get all confused and think it's an empty tree (like I just did).

Sorry!

Quoted 2 lines

There were no replies to v2 of the patch series. It all looks reasonable from a quick scan (assuming the patches are unchanged since then).

I haven't changed them, correct.

Quoted 1 line

afaik these patches have been tested by nobody except thyself?

I've tested them myself, then I sent them to the perf team who ran the (4 hour long) benchmark, and they reported success. As with many patches these days, they sank into a pit of indifference. Perhaps I need to take a leaf from my former government's book and sex up my patch descriptions a bit.

Signature · 10 lines
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
maintainer
#3 lore raw
Quoted 5 lines · On Mon, 28 Jan 2008 19:45:25 -0700 Matthew Wilcox <[email protected]> wrote:
Quoted 1 line

afaik these patches have been tested by nobody except thyself?

I've tested them myself, then I sent them to the perf team who ran the (4 hour long) benchmark, and they reported success. As with many patches these days, they sank into a pit of indifference.

I like to think that's because everyone is all fired up about bugfixes and the regression reports. heh.

It's a simple matter for me to add another git tree, which gets things a bit more exposure.

Quoted 3 lines

Perhaps I need to
take a leaf from my former government's book and sex up my patch descriptions a bit.

Well these two pulls came with effectively no description at all. Put yourself in Linus's position...

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#4 lore raw
In reply to Matthew Wilcox
Quoted 11 lines · Matthew Wilcox

G'day Linus, mate

Could you pull the dmapool branch of
git://git.kernel.org/pub/scm/linux/kernel/git/willy/misc.git please?

All the patches have been posted to linux-kernel before, and various comments (and acks) have been taken into account.

It's a fairly nice performance improvement, so would be good to get in. It's survived a few hours of *mumble* high-stress database benchmark, so I have high confidence in its stability.

I haven't looked at this yet but, I've been doing some work with the IOMMU performance impacts on DMA operations. DMApooling could provide a way to mitigate some of the spankage gotten when using IOMMU's.

--mgross

Quoted 12 lines
Signature · 11 lines
-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>