Skip to contentSkip to conversation

ata_piix.c: make piix_merge_scr() static

PATCH Applied Adrian Bunk 3 participants 3 messages Jan 28, 2008 – Feb 1, 2008 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ata_piix.c: make piix_merge_scr() static

piix_merge_scr() can become static.

---
f272ad2ac4274a59f0b43cfd65488c51855132d4

drivers/ata/ata_piix.c +1 -1
index a65c8ae..1a5c3bf 100644
@@ -1068,7 +1068,7 @@ static void piix_sidpr_write(struct ata_device *dev, unsigned int reg, u32 val)
 	iowrite32(val, hpriv->sidpr + PIIX_SIDPR_DATA);
 }
 
-u32 piix_merge_scr(u32 val0, u32 val1, const int * const *merge_tbl)
+static u32 piix_merge_scr(u32 val0, u32 val1, const int * const *merge_tbl)
 {
 	u32 val = 0;
 	int i, mi;
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Adrian Bunk

piix_merge_scr() can become static.

---
f272ad2ac4274a59f0b43cfd65488c51855132d4

drivers/ata/ata_piix.c +0 -0
index a65c8ae..1a5c3bf 100644

drivers/ata/ata_piix.c static void piix_sidpr_write(struct ata_device *dev, unsigned int reg, u32 val) · line 1074

Quoted 8 lines
drivers/ata/ata_piix.c +1 -1
@@ -1068,7 +1068,7 @@ static void piix_sidpr_write(struct ata_device *dev, unsigned int reg, u32 val)
 	iowrite32(val, hpriv->sidpr + PIIX_SIDPR_DATA);
 }
 
-u32 piix_merge_scr(u32 val0, u32 val1, const int * const *merge_tbl)
+static u32 piix_merge_scr(u32 val0, u32 val1, const int * const *merge_tbl)
 {
 	u32 val = 0;
 	int i, mi;

Ah.. right. Thanks. I somehow forgot static in front of it.

Signature · 1 line
tejun