Skip to contentSkip to conversation

let LOG_BUF_SHIFT default to 17

PATCH In review Adrian Bunk 4 participants 6 messages Jan 28, 2008 – Feb 11, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 let LOG_BUF_SHIFT default to 17

16 kB is often no longer enough for a normal boot of an UP system.

And even less when people e.g. use suspend.

17 seems to be a more reasonable default for current kernels on current hardware (it's just the default, anyone who is memory limited can still lower it).

---
f02213e3c1cb90ec1c66227f037110d489f30bfd

init/Kconfig +6 -9
index 0eda68f..81a1255 100644
@@ -272,17 +272,14 @@ config IKCONFIG_PROC
 config LOG_BUF_SHIFT
 	int "Kernel log buffer size (16 => 64KB, 17 => 128KB)"
 	range 12 21
-	default 17 if S390 || LOCKDEP
-	default 16 if X86_NUMAQ || IA64
-	default 15 if SMP
-	default 14
+	default 17
 	help
 	  Select kernel log buffer size as a power of 2.
-	  Defaults and Examples:
-	  	     17 => 128 KB for S/390
-		     16 => 64 KB for x86 NUMAQ or IA-64
-	             15 => 32 KB for SMP
-	             14 => 16 KB for uniprocessor
+	  Examples:
+	  	     17 => 128 KB
+		     16 => 64 KB
+	             15 => 32 KB
+	             14 => 16 KB
 		     13 =>  8 KB
 		     12 =>  4 KB
 
Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · On Tue, 29 Jan 2008 00:12:23 +0200 Adrian Bunk wrote:

16 kB is often no longer enough for a normal boot of an UP system.

s/16/64/ then agreed.

Quoted 40 lines

And even less when people e.g. use suspend.

17 seems to be a more reasonable default for current kernels on current hardware (it's just the default, anyone who is memory limited can still lower it).

---
f02213e3c1cb90ec1c66227f037110d489f30bfd

init/Kconfig +6 -10
index 0eda68f..81a1255 100644
@@ -272,17 +272,14 @@ config IKCONFIG_PROC
 config LOG_BUF_SHIFT
 	int "Kernel log buffer size (16 => 64KB, 17 => 128KB)"
 	range 12 21
-	default 17 if S390 || LOCKDEP
-	default 16 if X86_NUMAQ || IA64
-	default 15 if SMP
-	default 14
+	default 17
 	help
 	  Select kernel log buffer size as a power of 2.
-	  Defaults and Examples:
-	  	     17 => 128 KB for S/390
-		     16 => 64 KB for x86 NUMAQ or IA-64
-	             15 => 32 KB for SMP
-	             14 => 16 KB for uniprocessor
+	  Examples:
+	  	     17 => 128 KB
+		     16 => 64 KB
+	             15 => 32 KB
+	             14 => 16 KB
 		     13 =>  8 KB
 		     12 =>  4 KB
 
 
--
Quoted 5 lines

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

---
~Randy

#2 lore raw
In reply to Adrian Bunk
Quoted 1 line · Adrian Bunk

16 kB is often no longer enough for a normal boot of an UP system.

Better would be to just disable by default/remove noisy messages to make the kernel boot output shorter.

I think we got a lot of IMHO useless messages in there.

-Andi

#3 lore raw
Quoted 8 lines · Andi Kleen
Quoted 1 line · Adrian Bunk

16 kB is often no longer enough for a normal boot of an UP system.

Better would be to just disable by default/remove noisy messages to make the kernel boot output shorter.

I think we got a lot of IMHO useless messages in there.

Nearly 25% of the messages in my dmesg come from ACPI.

Plus many other messages that cover these generic resources stuff (e.g. BIOS map or ioport/iomem reservations).

All of these tend to be of great help when debugging driver regressions, since diff'ing the dmesg's often is enough for determining whether it's a driver problem or a PCI/ACPI/whatever problem.

Quoted 1 line

-Andi

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#4 lore raw
In reply to Adrian Bunk
Quoted 7 lines · Adrian Bunk

16 kB is often no longer enough for a normal boot of an UP system.

And even less when people e.g. use suspend.

17 seems to be a more reasonable default for current kernels on current hardware (it's just the default, anyone who is memory limited can still lower it).

agreed - but i think the default should be even higher. Many reported dmesg's are truncated at the really interesting bits so it's a real problem in practice.

Ingo

#5 lore raw
Quoted 7 lines · Ingo Molnar
Quoted 4 lines · Adrian Bunk

16 kB is often no longer enough for a normal boot of an UP system.

And even less when people e.g. use suspend.

Quoted 7 lines
Quoted 3 lines

17 seems to be a more reasonable default for current kernels on current hardware (it's just the default, anyone who is memory limited can still lower it).

agreed - but i think the default should be even higher. Many reported dmesg's are truncated at the really interesting bits so it's a real problem in practice.

17 is 128 kB.

Do we really have that many truncated dmesg's with LOG_BUF_SHIFT=17?

Quoted 1 line

Ingo

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed