Skip to contentSkip to conversation

Remove __INIT_REFOK and __INITDATA_REFOK

PATCH In review Ralf Baechle 2 participants 2 messages Jan 30, 2008 – Feb 2, 2008 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove __INIT_REFOK and __INITDATA_REFOK

Commit 312b1485fb509c9bc32eda28ad29537896658cb8 made __INIT_REFOK expand into .section .section ".ref.text", "ax". Since the assembler doesn't tolerate stuttering in the source that broke all MIPS builds.

Since with this change Sam downgraded __INIT_REFOK to just a backward compat thing and there being only a single use in the MIPS arch code the best solution is to delete both of __INIT_REFOK and __INITDATA_REFOK (which was equally broken) being unused anyway these can be deleted.

---

I'll send out the MIPS bits as part of my next pull request to Linus.

include/linux/init.h +0 -3
index 2efbda0..90cdbbb 100644
@@ -124,9 +124,6 @@
 #define __REF            .section       ".ref.text", "ax"
 #define __REFDATA        .section       ".ref.data", "aw"
 #define __REFCONST       .section       ".ref.rodata", "aw"
-/* backward compatibility */
-#define __INIT_REFOK     .section	__REF
-#define __INITDATA_REFOK .section	__REFDATA
 
 #ifndef __ASSEMBLY__
 /*
#1 lore raw
Quoted 10 lines · Ralf Baechle

Commit 312b1485fb509c9bc32eda28ad29537896658cb8 made __INIT_REFOK expand into .section .section ".ref.text", "ax". Since the assembler doesn't tolerate stuttering in the source that broke all MIPS builds.

Since with this change Sam downgraded __INIT_REFOK to just a backward compat thing and there being only a single use in the MIPS arch code the best solution is to delete both of __INIT_REFOK and __INITDATA_REFOK (which was equally broken) being unused anyway these can be deleted.

Thanks Ralf - applied.
And sorry for the MIPS breakage.

Sam