make struct ipv4_devconf static

PATCH In review Adrian Bunk 2 participants 2 messages Jan 30, 2008 – Jan 31, 2008

Subsystems (3)

Networking Network drivers IPv4/IPv6

lore

Share & tools

lore

Adrian Bunk

author

2008-01-30 20:02 UTC #0 lore raw

PATCH 1/1 make struct ipv4_devconf static

struct ipv4_devconf can now become static.

Signed-off-by Adrian Bunk <[email protected]>

---

 include/linux/inetdevice.h |    2 --
 net/ipv4/devinet.c         |    2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

20262a3317069b1bdbf2b37f4002fa5322445914

include/linux/inetdevice.h +0 -2

index 8d9eaae..fc4e3db 100644
@@ -17,8 +17,6 @@ struct ipv4_devconf
 	DECLARE_BITMAP(state, __NET_IPV4_CONF_MAX - 1);
 };
 
-extern struct ipv4_devconf ipv4_devconf;
-
 struct in_device
 {
 	struct net_device	*dev;

net/ipv4/devinet.c +1 -1

index 21f71bf..5ab5acc 100644
@@ -64,7 +64,7 @@
 #include <net/rtnetlink.h>
 #include <net/net_namespace.h>
 
-struct ipv4_devconf ipv4_devconf = {
+static struct ipv4_devconf ipv4_devconf = {
 	.data = {
 		[NET_IPV4_CONF_ACCEPT_REDIRECTS - 1] = 1,
 		[NET_IPV4_CONF_SEND_REDIRECTS - 1] = 1,

Pavel Emelyanov

Acked-by on v1 1/1

2008-01-31 10:37 UTC #1 lore raw

Quoted 3 lines · Adrian Bunk

struct ipv4_devconf can now become static.
Signed-off-by Adrian Bunk <[email protected]>

Acked-by Pavel Emelyanov <[email protected]>

Quoted 35 lines

---

 include/linux/inetdevice.h |    2 --
 net/ipv4/devinet.c         |    2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

20262a3317069b1bdbf2b37f4002fa5322445914

include/linux/inetdevice.h +0 -2

index 8d9eaae..fc4e3db 100644
@@ -17,8 +17,6 @@ struct ipv4_devconf
 	DECLARE_BITMAP(state, __NET_IPV4_CONF_MAX - 1);
 };
 
-extern struct ipv4_devconf ipv4_devconf;
-
 struct in_device
 {
 	struct net_device	*dev;

net/ipv4/devinet.c +1 -1

index 21f71bf..5ab5acc 100644
@@ -64,7 +64,7 @@
 #include <net/rtnetlink.h>
 #include <net/net_namespace.h>
 
-struct ipv4_devconf ipv4_devconf = {
+static struct ipv4_devconf ipv4_devconf = {
 	.data = {
 		[NET_IPV4_CONF_ACCEPT_REDIRECTS - 1] = 1,
 		[NET_IPV4_CONF_SEND_REDIRECTS - 1] = 1,