Skip to contentSkip to conversation

PATCH] x86_64: fix comments in vmlinux_64.lds

PATCH Yinghai Lu 2 participants 3 messages Jan 31, 2008 x86

lore
Share & tools
lore

Yinghai Lu

author
#0 lore raw

[PATCH] x86_64: fix comments in vmlinux_64.lds

for bzImage, the vmlinux_64.lds still have s32 bit code, and startup_32 should bt 0. fix the comment

arch/x86/boot/compressed/vmlinux_64.lds +1 -1
index f6e5b44..7e5c720 100644
@@ -3,7 +3,7 @@ OUTPUT_ARCH(i386:x86-64)
 ENTRY(startup_64)
 SECTIONS
 {
-	/* Be careful parts of head_64.S assume startup_64 is at
+	/* Be careful parts of head_64.S assume startup_32 is at
 	 * address 0.
 	 */
 	. = 0;
#1 lore raw

arch/x86/boot/compressed/vmlinux_64.lds OUTPUT_ARCH(i386:x86-64) · line 9

Quoted 8 lines · Yinghai Lu

ENTRY(startup_64)
SECTIONS
{

arch/x86/boot/compressed/vmlinux_64.lds +1 -1
-	/* Be careful parts of head_64.S assume startup_64 is at
+	/* Be careful parts of head_64.S assume startup_32 is at
 	 * address 0.
 	 */
 	. = 0;

but this linker script rule is about startup_64, not about startup_32.

startup_32 does exist on 64-bit too (and is 32-bit code), but it's linked to a different address that is not 0:

ffffffff806c23c0 r startup_32

startup_64 is at offset 0:

ffffffff80200000 T startup_64

So your patch looks wrong to me.

Ingo

author
#2 lore raw
Quoted 17 lines · Ingo Molnar

arch/x86/boot/compressed/vmlinux_64.lds OUTPUT_ARCH(i386:x86-64) · line 9

Quoted 8 lines · Yinghai Lu

ENTRY(startup_64)
SECTIONS
{

arch/x86/boot/compressed/vmlinux_64.lds +1 -1
-	/* Be careful parts of head_64.S assume startup_64 is at
+	/* Be careful parts of head_64.S assume startup_32 is at
 	 * address 0.
 	 */
 	. = 0;

but this linker script rule is about startup_64, not about startup_32.

startup_32 does exist on 64-bit too (and is 32-bit code), but it's linked to a different address that is not 0:

Quoted 7 lines

ffffffff806c23c0 r startup_32

startup_64 is at offset 0:

ffffffff80200000 T startup_64

So your patch looks wrong to me.

there are several startup_32 in 64 bit
1. one is for bzImage, it is arch/x86/boot/compressed/head_64.S, and it said startup_64 will at 0x200. that what i mean
2. one is vmlinux in linux-2.6/ , it is in arch/x86/kernel/trampoline_64.S it is for AP trampoline and wake up. that is what you mean

actually there was another one in arch/x86_64/kernel/head_64.S, and it was removed when Eric made linux-2.6/vmlinux to be 64bit elf.

So that patch is needed.

YH