spi_bfin: wait for tx to complete on full duplex paths
PATCH 4/6 spi_bfin: wait for tx to complete on full duplex paths
From: Bryan Wu <[email protected]>
Full duplex SPI operation should not read a dummy byte at the first transfer. Bug and fix by Jean-Christian de Rivaz <[email protected]>:
Signed-off-by Jean-Christian de Rivaz <[email protected]>
Signed-off-by Bryan Wu <[email protected]>
Signed-off-by David Brownell <[email protected]>
--- drivers/spi/spi_bfin5xx.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-)
drivers/spi/spi_bfin5xx.c +3 -15
@@ -358,14 +358,10 @@ static void u8_cs_chg_reader(struct drivstatic void u8_duplex (struct driver_data *drv_data) { -/* poll for SPI completion before start */ -while (!(read_STAT (drv_data) &BIT_STAT_SPIF )) -cpu_relax (); -/* in duplex mode, clk is triggered by writing of TDBR */ while (drv_data->rx < drv_data->rx_end) {write_TDBR (drv_data, (*(u8 *) (drv_data->tx))); -while (read_STAT (drv_data) &BIT_STAT_TXS ) +while (!(read_STAT (drv_data) &BIT_STAT_SPIF ))cpu_relax ();while (!(read_STAT (drv_data) &BIT_STAT_RXS ))cpu_relax ();
@@ -495,14 +491,10 @@ static void u16_cs_chg_reader(struct dristatic void u16_duplex (struct driver_data *drv_data) { -/* poll for SPI completion before start */ -while (!(read_STAT (drv_data) &BIT_STAT_SPIF )) -cpu_relax (); -/* in duplex mode, clk is triggered by writing of TDBR */ while (drv_data->tx < drv_data->tx_end) {write_TDBR (drv_data, (*(u16 *) (drv_data->tx))); -while (read_STAT (drv_data) &BIT_STAT_TXS ) +while (!(read_STAT (drv_data) &BIT_STAT_SPIF ))cpu_relax ();while (!(read_STAT (drv_data) &BIT_STAT_RXS ))cpu_relax ();
@@ -516,15 +508,11 @@ static void u16_cs_chg_duplex(struct dri {struct chip_data *chip = drv_data->cur_chip; -/* poll for SPI completion before start */ -while (!(read_STAT (drv_data) &BIT_STAT_SPIF )) -cpu_relax (); -while (drv_data->tx < drv_data->tx_end) {cs_active (drv_data, chip);write_TDBR (drv_data, (*(u16 *) (drv_data->tx))); -while (read_STAT (drv_data) &BIT_STAT_TXS ) +while (!(read_STAT (drv_data) &BIT_STAT_SPIF ))cpu_relax ();while (!(read_STAT (drv_data) &BIT_STAT_RXS ))cpu_relax ();
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/