Skip to contentSkip to conversation

latencytop: Change Kconfig dependency.

PATCH Applied Heiko Carstens 3 participants 6 messages Feb 1, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 latencytop: Change Kconfig dependency.

From: Heiko Carstens <[email protected]>

Change latencytop Kconfig entry so it doesn't list the archictectures that support it. Instead introduce HAVE_LATENCY_SUPPORT which any architecture can set. Should reduce patch conflicts.

Cc Arjan van de Ven <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Martin Schwidefsky <[email protected]>
Cc Holger Wolf <[email protected]>

---

If ok, should this go in via the x86 tree?

 arch/x86/Kconfig  |    3 +++
 lib/Kconfig.debug |    2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
arch/x86/Kconfig +3 -0
Index: linux-2.6/arch/x86/Kconfig
===================================================================
@@ -44,6 +44,9 @@ config LOCKDEP_SUPPORT
 config STACKTRACE_SUPPORT
 	def_bool y
 
+config HAVE_LATENCYTOP_SUPPORT
+	def_bool y
+
 config SEMAPHORE_SLEEPERS
 	def_bool y
 
lib/Kconfig.debug +1 -1
Index: linux-2.6/lib/Kconfig.debug
===================================================================
@@ -581,7 +581,7 @@ config LATENCYTOP
 	select STACKTRACE
 	select SCHEDSTATS
 	select SCHED_DEBUG
-	depends on X86 || X86_64
+	depends on HAVE_LATENCYTOP_SUPPORT
 	help
 	  Enable this option if you want to use the LatencyTOP tool
 	  to find out which userspace is blocking on what kernel operations.
Applied
#1 lore raw
Quoted 5 lines · Heiko Carstens

From: Heiko Carstens <[email protected]>

Change latencytop Kconfig entry so it doesn't list the archictectures that support it. Instead introduce HAVE_LATENCY_SUPPORT which any architecture can set. Should reduce patch conflicts.

thanks, applied.

Ingo

#2 lore raw
In reply to Heiko Carstens
Quoted 24 lines · Heiko Carstens

From: Heiko Carstens <[email protected]>

Change latencytop Kconfig entry so it doesn't list the archictectures that support it. Instead introduce HAVE_LATENCY_SUPPORT which any architecture can set. Should reduce patch conflicts.

Cc Arjan van de Ven <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Martin Schwidefsky <[email protected]>
Cc Holger Wolf <[email protected]>

---

If ok, should this go in via the x86 tree?

 arch/x86/Kconfig  |    3 +++
 lib/Kconfig.debug |    2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

Index: linux-2.6/arch/x86/Kconfig
===================================================================

arch/x86/Kconfig config LOCKDEP_SUPPORT · line 49

Quoted 6 lines
arch/x86/Kconfig +3 -0
@@ -44,6 +44,9 @@ config LOCKDEP_SUPPORT
 config STACKTRACE_SUPPORT
 	def_bool y
 
+config HAVE_LATENCYTOP_SUPPORT
+	def_bool y
+

No.
Please do:
config X86
+ select HAVE_LATENCYTOP_SUPPORT

Yes - this is a valid use of select.

See Documentation/kbuild/kconfig-language.txt

Sam

#3 lore raw
Quoted 11 lines · Sam Ravnborg

arch/x86/Kconfig config LOCKDEP_SUPPORT · line 49

Quoted 6 lines

config STACKTRACE_SUPPORT

arch/x86/Kconfig +3 -0
 	def_bool y
 
+config HAVE_LATENCYTOP_SUPPORT
+	def_bool y
+

No.
Please do:
config X86

(quoted diff) +1 -0
+	select HAVE_LATENCYTOP_SUPPORT
Quoted 1 line

Yes - this is a valid use of select.

i see - and there's lots of other examples of this and other similar things in other architectures as well. Could we do that as a separate cleanup patch instead, to keep the Kconfig file consistently structured.

Ingo

#4 lore raw
Quoted 14 lines · Ingo Molnar
Quoted 11 lines · Sam Ravnborg

arch/x86/Kconfig config LOCKDEP_SUPPORT · line 49

Quoted 6 lines

config STACKTRACE_SUPPORT

arch/x86/Kconfig +3 -0
 	def_bool y
 
+config HAVE_LATENCYTOP_SUPPORT
+	def_bool y
+

No.
Please do:
config X86

(quoted diff) +1 -0
+	select HAVE_LATENCYTOP_SUPPORT
Quoted 5 lines
Quoted 1 line

Yes - this is a valid use of select.

i see - and there's lots of other examples of this and other similar things in other architectures as well. Could we do that as a separate cleanup patch instead, to keep the Kconfig file consistently structured.

I would prefer new stuff to use the recommended method. But I have no strong feelign for it and at the moment I am fed up in Section mismatch warnings :-(

Sam

#5 lore raw
In reply to Sam Ravnborg
Quoted 11 lines

arch/x86/Kconfig config LOCKDEP_SUPPORT · line 49

Quoted 3 lines
arch/x86/Kconfig +3 -0
+config HAVE_LATENCYTOP_SUPPORT
+	def_bool y
+

No.
Please do:
config X86

(quoted diff) +1 -0
+	select HAVE_LATENCYTOP_SUPPORT

Yes - this is a valid use of select.

See Documentation/kbuild/kconfig-language.txt

Ok, I wasn't aware of that. For now I'll leave it as is as Ingo requested.