Skip to contentSkip to conversation

Fix ext4 bitops

PATCH In review Bastian Blank 3 participants 3 messages Feb 1, 2008 – Feb 4, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix ext4 bitops

Fix ext4 bitops.

include/asm-powerpc/bitops.h +2 -0
index 220d9a7..d0980df 100644
@@ -363,6 +363,8 @@ unsigned long generic_find_next_le_bit(const unsigned long *addr,
 				    unsigned long size, unsigned long offset);
 /* Bitmap functions for the ext2 filesystem */
 
+#include <asm-generic/bitops/le.h>
+
 #define ext2_set_bit(nr,addr) \
 	__test_and_set_le_bit((nr), (unsigned long*)addr)
 #define ext2_clear_bit(nr, addr) \
#1 lore raw
Quoted 1 line · Bastian Blank

Fix ext4 bitops.

Please provide a better description, as it's not obvious at first sight.

include/asm-powerpc/bitops.h unsigned long generic_find_next_le_bit(const unsigned long *addr, · line 366

Quoted 11 lines
include/asm-powerpc/bitops.h +1 -0
index 220d9a7..d0980df 100644
@@ -363,6 +363,8 @@ unsigned long generic_find_next_le_bit(const unsigned long *addr,
 				    unsigned long size, unsigned long offset);
 /* Bitmap functions for the ext2 filesystem */
 
+#include <asm-generic/bitops/le.h>

A comment would be useful to indicate that this defines the _le versions of the bitops as it would be easy to mistake that for something else.

Quoted 7 lines
include/asm-powerpc/bitops.h +0 -0
 #define ext2_set_bit(nr,addr) \
 	__test_and_set_le_bit((nr), (unsigned long*)addr)
 #define ext2_clear_bit(nr, addr) \

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

#2 lore raw
In reply to Bastian Blank
Quoted 9 lines · Bastian Blank

Fix ext4 bitops.

include/asm-powerpc/bitops.h +0 -0
index 220d9a7..d0980df 100644

include/asm-powerpc/bitops.h unsigned long generic_find_next_le_bit(const unsigned long *addr, · line 370

Quoted 8 lines
include/asm-powerpc/bitops.h +2 -0
@@ -363,6 +363,8 @@ unsigned long generic_find_next_le_bit(const unsigned long *addr,
 				    unsigned long size, unsigned long offset);
 /* Bitmap functions for the ext2 filesystem */
 
+#include <asm-generic/bitops/le.h>
+
 #define ext2_set_bit(nr,addr) \
 	__test_and_set_le_bit((nr), (unsigned long*)addr)
 #define ext2_clear_bit(nr, addr) \

I am not sure what the changes are for. Can you send me the build logs with the compile error. I always test Ext4 on powerpc so not sure what went wrong.

-aneesh