checkpatch: add __asm__ to function-space-paren exception list
PATCH 1/1 checkpatch: add __asm__ to function-space-paren exception list
checkpatch.pl thinks that __asm__ is a function name, so it complains about a space between the function name and a parenthesis when it sees "__asm__ ("mov ax,bx")".
This change will also encourage developers to use '__asm__' instead of 'asm'.
--- scripts/checkpatch.pl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
scripts/checkpatch.pl +1 -1
@@ -1115,7 +1115,7 @@ sub process { # check for spaces between functions and their parentheses. while ($line =~ /($Ident)\s+\(/g) { - if ($1 !~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case)$/ && + if ($1 !~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case|__asm__)$/ && $line !~ /$Type\s+\(/ && $line !~ /^.\#\s*define\b/) { WARN("no space between function name and open parenthesis '('\n" . $herecurr); }
Signature · 1 line
1.5.2.4
Quoted 17 lines · Timur Tabi
checkpatch.pl thinks that
__asm__is a function name, so it complains about a space between the function name and a parenthesis when it sees "__asm__("mov ax,bx")".This change will also encourage developers to use '
__asm__' instead of 'asm'.Signed-off-by Timur Tabi <[email protected]>--- scripts/checkpatch.pl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)scripts/checkpatch.pl +0
-0
scripts/checkpatch.pl sub process { · line 1121
Quoted 8 lines
scripts/checkpatch.pl +1
-1@@ -1115,7 +1115,7 @@ sub process { # check for spaces between functions and their parentheses. while ($line =~ /($Ident)\s+\(/g) { - if ($1 !~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case)$/ && + if ($1 !~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case|__asm__)$/ && $line !~ /$Type\s+\(/ && $line !~ /^.\#\s*define\b/) { WARN("no space between function name and open parenthesis '('\n" . $herecurr); }
It truly is not clear what "type" of thing an __asm__ is these days. Cirtainly it seems we can use it as an attribute of a type:
register unsigned long __r16 __asm__("$16") = rtc_access->function;and yet also in its more traditional form:
__asm__(" call foo");The latter form feels like a function? But cirtainly in the examples it is shown with a space some of the time, and not others. Is __asm__ an attribute of the null function (;) in this context or ... well ?
This patch really just removes any checks for spacing on __asm__ do we have a preferred style for these? Attributes do seem to have spaces, though in their most attribute like usage the __asm__ "attribute" does not seem to be used with a space, so far anyhow.
Oh and why are we preferring the use of __asm__ over asm? They both seem valid. Should we be recommending one over the other?
-apw
Quoted 10 lines · Andy Whitcroft
It truly is not clear what "type" of thing an
__asm__is these days. Cirtainly it seems we can use it as an attribute of a type:register unsigned long __r16 __asm__("$16") = rtc_access->function;and yet also in its more traditional form:
__asm__(" call foo");The latter form feels like a function?
But it's not. Sure, it defines a block of code that has input and output parameters, but one key distinction is that __asm__ is not the name of the "function".
? But cirtainly in the examples it
Quoted 1 line
is shown with a space some of the time, and not others.
Well, since checkpatch.pl insists that the space be removed, that's probably why it's not there a lot of the time.
Quoted 2 lines
Is
__asm__an
attribute of the null function (;) in this context or ... well ?
I don't think __asm__ can be compared to other C-language syntax constructs.
Quoted 2 lines
This patch really just removes any checks for spacing on
__asm__do we have a preferred style for these?
I don't know, but I do know it's wrong for checkpatch.pl to think that "__asm__" is the name of a function.
Quoted 3 lines
Attributes do seem to have spaces,
though in their most attribute like usage the__asm__"attribute" does not seem to be used with a space, so far anyhow.
The problem is that checkpatch.pl thinks this is okay:
__asm__ __volatile__ ("call foo");but it doesn't like this:
__asm__ ("call foo");Quoted 2 lines
Oh and why are we preferring the use of
__asm__over asm? They both seem valid. Should we be recommending one over the other?
It's a toss-up. Depending on the architecture, one version has about 60% usage and the other about 40%. I thought I read somewhere that __asm__ is preferred, but I can't remember where I read that or who wrote it.
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale