Skip to contentSkip to conversation

mpc83xx_spi.c breaks non-ppc ports

U-Boot-Users Mike Frysinger 2 participants 3 messages Feb 4, 2008 – Feb 5, 2008 SPI

lore
Share & tools
lore
#0 lore raw

Commit 04a9e1180ac76a7bacc15a6fcd95ad839d65bddb introduced the mpc83xx_spi.c driver which gets compiled for everyone, but this obviously only builds for the ppc port. I haven't been following the latest build updates, but the attached patch is one way to fix things.

---

drivers/spi/Makefile +3 -1
index 0b7a2df..1fdfb38 100644
@@ -25,7 +25,9 @@ include $(TOPDIR)/config.mk
 
 LIB	:= $(obj)libspi.a
 
-COBJS-y += mpc8xxx_spi.o
+COBJS-ppc += mpc8xxx_spi.o
+
+COBJS-y += $(COBJS-$(ARCH))
 
 COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080204/c055d009/attachment.pgp

#1 lore raw
Quoted 7 lines · On Mon, 4 Feb 2008 17:57:23 -0500 Mike Frysinger <[email protected]> wrote:

Commit 04a9e1180ac76a7bacc15a6fcd95ad839d65bddb introduced the mpc83xx_spi.c driver which gets compiled for everyone, but this obviously only builds for the ppc port. I haven't been following the latest build updates, but the attached patch is one way to fix things.

---

there's a better fix here:

http://article.gmane.org/gmane.comp.boot-loaders.u-boot/36039

that I also pushed and have a pull request pending for WD to pick it up.

Kim

Quoted 16 lines
drivers/spi/Makefile +3 -1
index 0b7a2df..1fdfb38 100644
@@ -25,7 +25,9 @@ include $(TOPDIR)/config.mk
 
 LIB	:= $(obj)libspi.a
 
-COBJS-y += mpc8xxx_spi.o
+COBJS-ppc += mpc8xxx_spi.o
+
+COBJS-y += $(COBJS-$(ARCH))
 
 COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)
#2 lore raw
Quoted 6 lines · Kim Phillips
Quoted 5 lines · Mike Frysinger

Commit 04a9e1180ac76a7bacc15a6fcd95ad839d65bddb introduced the mpc83xx_spi.c driver which gets compiled for everyone, but this obviously only builds for the ppc port. I haven't been following the latest build updates, but the attached patch is one way to fix things.

Quoted 8 lines
Quoted 2 lines

---

there's a better fix here:

http://article.gmane.org/gmane.comp.boot-loaders.u-boot/36039

that I also pushed and have a pull request pending for WD to pick it up.

thanks ... i googled but didnt find anything but the original pull request -mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080204/c09aa4bb/attachment.pgp