Skip to contentSkip to conversation

udf: next round of cleanups

PATCH In review [email protected] 2 participants 2 messages Feb 3, 2008 – Feb 4, 2008

lore
Share & tools
lore
#0 lore raw

cover udf: next round of cleanups

Hi

This patchset contains next round of various UDF fs cleanups.

[PATCH 1/6] udf: udf_get_block, inode_bmap - remove unneeded checks

[PATCH 2/6] udf: create function for conversion from timestamp to timespec [PATCH 3/6] udf: convert udf_stamp_to_time to return struct timespec [PATCH 4/6] udf: convert udf_stamp_to_time and udf_time_to_stamp to use timestamps [PATCH 5/6] udf: remove unneeded kernel_timestamp type
These 4 patches can be folded into one if requested, but I think it's easier to analyze them when they are split.

[PATCH 6/6] udf: super.c reorganization
Pretty mechanical work. Can be dropped and redone if it will conflict with someone else patch.

 fs/udf/ecma_167.h |   13 -
 fs/udf/inode.c    |  183 ++++++-----------
 fs/udf/super.c    |  553 ++++++++++++++++++++++++++----------------------------
 fs/udf/udfdecl.h  |    8 
 fs/udf/udfend.h   |   22 --
 fs/udf/udftime.c  |   39 +--
 6 files changed, 358 insertions(+), 460 deletions(-)

Applies on top of patches I've sent lately (http://lkml.org/lkml/2008/1/30/482)

Jan: Are you going to create git tree for udf?

Marcin Slusarz

#1 lore raw
Quoted 25 lines · On Sun 03-02-08 19:33:45, [email protected] wrote:

Hi

This patchset contains next round of various UDF fs cleanups.

[PATCH 1/6] udf: udf_get_block, inode_bmap - remove unneeded checks

[PATCH 2/6] udf: create function for conversion from timestamp to timespec [PATCH 3/6] udf: convert udf_stamp_to_time to return struct timespec [PATCH 4/6] udf: convert udf_stamp_to_time and udf_time_to_stamp to use timestamps [PATCH 5/6] udf: remove unneeded kernel_timestamp type
These 4 patches can be folded into one if requested, but I think it's easier to analyze them when they are split.

[PATCH 6/6] udf: super.c reorganization
Pretty mechanical work. Can be dropped and redone if it will conflict with someone else patch.

 fs/udf/ecma_167.h |   13 -
 fs/udf/inode.c    |  183 ++++++-----------
 fs/udf/super.c    |  553 ++++++++++++++++++++++++++----------------------------
 fs/udf/udfdecl.h  |    8 
 fs/udf/udfend.h   |   22 --
 fs/udf/udftime.c  |   39 +--
 6 files changed, 358 insertions(+), 460 deletions(-)
Quoted 3 lines

Applies on top of patches I've sent lately (http://lkml.org/lkml/2008/1/30/482)

Jan: Are you going to create git tree for udf?

I was already thinking about it to take some burden from Andrew. So if
you think you are going to have more time for these cleanups then I can setup one (it would be useless when I send to Andrew one fix per month ;)...

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR