Skip to contentSkip to conversation

Nikon D80 usb-storage quirk needs modified, new FW

PATCH In review Konstantin Kletschke 3 participants 5 messages Feb 5, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Nikon D80 usb-storage quirk needs modified, new FW

Nikon did update their FW for the Nikon D80 and usb-storage got unusable:

scsi 10:0:0:0: Direct-Access NIKON D80 1.10 PQ: 0 ANSI: 2
sd 10:0:0:0: [sdb] 3970049 512-byte hardware sectors (2033 MB) sd 10:0:0:0: [sdb] Write Protect is off
sd 10:0:0:0: [sdb] Mode Sense: 0f 00 00 00
sd 10:0:0:0: [sdb] Assuming drive cache: write through sd 10:0:0:0: [sdb] 3970049 512-byte hardware sectors (2033 MB) sd 10:0:0:0: [sdb] Write Protect is off
sd 10:0:0:0: [sdb] Mode Sense: 0f 00 00 00
sd 10:0:0:0: [sdb] Assuming drive cache: write through
sdb: sdb1
sd 10:0:0:0: [sdb] Attached SCSI removable disk
sd 10:0:0:0: Attached scsi generic sg2 type 0
usb-storage: device scan complete
end_request: I/O error, dev sdb, sector 3970048
printk: 56 messages suppressed.
Buffer I/O error on device sdb, logical block 3970048
end_request: I/O error, dev sdb, sector 3970048

or with another SDCARD:

scsi 8:0:0:0: Direct-Access NIKON D80 1.10 PQ: 0 ANSI: 2
sd 8:0:0:0: [sdb] 3970049 512-byte hardware sectors (2033 MB) sd 8:0:0:0: [sdb] Write Protect is off
sd 8:0:0:0: [sdb] Mode Sense: 0f 00 00 00
sd 8:0:0:0: [sdb] Assuming drive cache: write through sd 8:0:0:0: [sdb] 3970049 512-byte hardware sectors (2033 MB) sd 8:0:0:0: [sdb] Write Protect is off
sd 8:0:0:0: [sdb] Mode Sense: 0f 00 00 00
sd 8:0:0:0: [sdb] Assuming drive cache: write through
sdb: sdb1
sd 8:0:0:0: [sdb] Attached SCSI removable disk
sd 8:0:0:0: Attached scsi generic sg2 type 0
usb-storage: device scan complete
usb 4-2: reset high speed USB device using ehci_hcd and address 7 usb 4-2: reset high speed USB device using ehci_hcd and address 7
end_request: I/O error, dev sdb, sector 3970048
printk: 51 messages suppressed.
Buffer I/O error on device sdb, logical block 3970048
end_request: I/O error, dev sdb, sector 3970048
Buffer I/O error on device sdb, logical block 3970048
end_request: I/O error, dev sdb, sector 3970048
Buffer I/O error on device sdb, logical block 3970048
end_request: I/O error, dev sdb, sector 3970048
Buffer I/O error on device sdb, logical block 3970048
end_request: I/O error, dev sdb, sector 3970048
Buffer I/O error on device sdb, logical block 3970048 usb 4-2: reset high speed USB device using ehci_hcd and address 7 usb 4-2: reset high speed USB device using ehci_hcd and address 7 usb 4-2: reset high speed USB device using ehci_hcd and address 7 usb 4-2: reset high speed USB device using ehci_hcd and address 7 usb 4-2: can't restore configuration #1 (error=-71)
usb 4-2: USB disconnect, address 7
sd 8:0:0:0: [sdb] Result: hostbyte=0x07 driverbyte=0x00
end_request: I/O error, dev sdb, sector 3969985
Buffer I/O error on device sdb, logical block 3969985 sd 8:0:0:0: [sdb] Result: hostbyte=0x07 driverbyte=0x00
end_request: I/O error, dev sdb, sector 3970032
sd 8:0:0:0: [sdb] Result: hostbyte=0x07 driverbyte=0x00
end_request: I/O error, dev sdb, sector 3970048
sd 8:0:0:0: [sdb] Result: hostbyte=0x07 driverbyte=0x00
end_request: I/O error, dev sdb, sector 3970048
sd 8:0:0:0: [sdb] Result: hostbyte=0x07 driverbyte=0x00
end_request: I/O error, dev sdb, sector 40

I relized the unusal_devs.h needs to be adapted to reflect new FW Version, then it works fine again:

drivers/usb/storage/unusual_devs.h 2008-02-05 13:32:22.926623601 +0100 renamed from drivers/usb/storage/unusual_devs.h_orig 2008-02-05 13:33:55.010623616 +0100 +1 -1
@@ -342,7 +342,7 @@
                US_FL_FIX_CAPACITY),
 
 /* Reported by Emil Larsson <[email protected]> */
-UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0101,
+UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0110,
                "NIKON",
                "NIKON DSC D80",
                US_SC_DEVICE, US_PR_DEVICE, NULL,

What I wonder is, why are there other examples only reflecting the newest Firmware, are older ones also catched?

Kind Regards, Konsti

Signature · 2 lines
GPG KeyID EF62FCEF
Fingerprint: 13C9 B16B 9844 EC15 CC2E  A080 1E69 3FDA EF62 FCEF
#1 lore raw
Quoted 2 lines · Konstantin Kletschke

Nikon did update their FW for the Nikon D80 and usb-storage got unusable:

[...]

Quoted 16 lines

I relized the unusal_devs.h needs to be adapted to reflect new FW Version, then it works fine again:

drivers/usb/storage/unusual_devs.h 2008-02-05 13:32:22.926623601 +0100 renamed from drivers/usb/storage/unusual_devs.h_orig 2008-02-05 13:33:55.010623616 +0100 +1 -1
@@ -342,7 +342,7 @@
                US_FL_FIX_CAPACITY),
 
 /* Reported by Emil Larsson <[email protected]> */
-UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0101,
+UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0110,
                "NIKON",
                "NIKON DSC D80",
                US_SC_DEVICE, US_PR_DEVICE, NULL,
Quoted 2 lines

What I wonder is, why are there other examples only reflecting the newest Firmware, are older ones also catched?

Maybe you should leave them both here.

Xav

#2 lore raw

Am 2008-02-05 14:26 +0100 schrieb Xavier Bestel:

Quoted 3 lines
Quoted 1 line

+UNUSUAL_DEV( 0x04b0, 0x0411, 0x0100, 0x0110,

Maybe you should leave them both here.

I suppose the device is checked against a range between bcdDeviceMin -> bcdDeviceMax to take care of the possibility new revisions does not need the quirk anymore but all older and bcdDeviceMax but I found the piece of code not yet. Lets see...

Konsti

Signature · 2 lines
GPG KeyID EF62FCEF
Fingerprint: 13C9 B16B 9844 EC15 CC2E  A080 1E69 3FDA EF62 FCEF
#3 lore raw
Quoted 10 lines · Konstantin Kletschke

Am 2008-02-05 14:26 +0100 schrieb Xavier Bestel:

Quoted 3 lines
Quoted 1 line

+UNUSUAL_DEV( 0x04b0, 0x0411, 0x0100, 0x0110,

Maybe you should leave them both here.

I suppose the device is checked against a range between bcdDeviceMin -> bcdDeviceMax to take care of the possibility new revisions does not need the quirk anymore but all older and bcdDeviceMax but I found the piece of code not yet. Lets see...

You're correct, the patch is fine in that respect. However
it is whitespace-corrupted and hence will not apply. You should also submit it directly to the usb-storage maintainer with the linux-usb (and maybe the usb-storage) list on CC.

Daniel

#4 lore raw

Am 2008-02-05 14:27 +0000 schrieb Daniel Drake:

Quoted 1 line

it is whitespace-corrupted and hence will not apply. You should also submit

ARGH! May be copy&paste with vim/xterm caused this. Is this better? Anything else should have created a clean patch *mumblegrumble*

Quoted 2 lines

it directly to the usb-storage maintainer with the linux-usb (and maybe the usb-storage) list on CC.

I will see, I did not yet.

Konsti

Signature · 2 lines
GPG KeyID EF62FCEF
Fingerprint: 13C9 B16B 9844 EC15 CC2E  A080 1E69 3FDA EF62 FCEF
drivers/usb/storage/unusual_devs.h renamed from drivers/usb/storage/unusual_devs.h_orig +1 -1
@@ -342,7 +342,7 @@
 		US_FL_FIX_CAPACITY),
 
 /* Reported by Emil Larsson <[email protected]> */
-UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0101,
+UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0110,
 		"NIKON",
 		"NIKON DSC D80",
 		US_SC_DEVICE, US_PR_DEVICE, NULL,