Skip to contentSkip to conversation

uml: handle unusual results from find_tempdir.

PATCH In review Jim Meyering 2 participants 2 messages Feb 5, 2008 User-mode Linux (UML)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uml: handle unusual results from find_tempdir.

An alternative: make find_tempdir set tempdir to default_tempdir upon malloc failure.

* arch/um/os-Linux/mem.c (make_tempfile): Handle NULL tempdir. Don't let a long tempdir (e.g., via TMPDIR) provoke heap corruption.

---
 arch/um/os-Linux/mem.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/um/os-Linux/mem.c +3 -0
index e114d09..1458385 100644
@@ -176,6 +176,9 @@ int __init make_tempfile(const char *template, char **out_tempname,
 	  return -1;
 
 	find_tempdir();
+	if (tempdir == NULL || strlen(tempdir) >= MAXPATHLEN)
+	  return -1;
+
 	if (template[0] != '/')
 		strcpy(tempname, tempdir);
 	else

--
1.5.4.19.gd3dfd

#1 lore raw
Quoted 8 lines · Jim Meyering

An alternative: make find_tempdir set tempdir to default_tempdir upon malloc failure.

* arch/um/os-Linux/mem.c (make_tempfile): Handle NULL tempdir. Don't let a long tempdir (e.g., via TMPDIR) provoke heap corruption.

Thanks, I'll forward this on.

Jeff

Signature · 1 line
Work email - jdike at linux dot intel dot com