Skip to contentSkip to conversation

PCIE ASPM support hangs my laptop pretty often

DISCUSSION Дамјан Георгиевски 7 participants 11 messages Feb 5, 2008 – Feb 19, 2008

lore
Share & tools
lore
#0 lore raw

I've patched my kernel with the PCIe ASPM and after setting echo powersave > /sys/module/pcie_aspm/parameters/policy

I started to experience random hangs of my laptop. Hardware info:
Thinkpad x60s 1704-5UG
also tested on a firends X60s 1702-F6U

Kernel is 2.6.24 + these patches:
tuxonice 3.0-rc5
thinkpad_acpi v0.19-20080107
tp_smapi 0.36

Signature · 1 line
Damjan Georgievski
#1 lore raw
Quoted 6 lines · On Tue, 5 Feb 2008 18:40:04 +0100 Дамјан Георгиевски…

I've patched my kernel with the PCIe ASPM and after setting echo powersave > /sys/module/pcie_aspm/parameters/policy

I started to experience random hangs of my laptop. Hardware info:
Thinkpad x60s 1704-5UG

the x60's chipset doesn't support ASPM properly afaik... bad idea.

Quoted 1 line
Signature · 3 lines
If you want to reach me at my work email, use [email protected]
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
#2 lore raw
Quoted 11 lines · Arjan van de Ven
Quoted 6 lines · On Tue, 5 Feb 2008 18:40:04 +0100 ???????????? ??????????????????????…

I've patched my kernel with the PCIe ASPM and after setting echo powersave > /sys/module/pcie_aspm/parameters/policy

I started to experience random hangs of my laptop. Hardware info:
Thinkpad x60s 1704-5UG

the x60's chipset doesn't support ASPM properly afaik... bad idea.

Well, the code shouldn't then cause a crash of the machine :)

thanks,

greg k-h

#3 lore raw
Quoted 7 lines · Greg KH
Quoted 6 lines · Arjan van de Ven
Quoted 3 lines · On Tue, 5 Feb 2008 18:40:04 +0100 ???????????? ??????????????????????…

I've patched my kernel with the PCIe ASPM and after setting echo powersave > /sys/module/pcie_aspm/parameters/policy

Quoted 6 lines
Quoted 4 lines
Quoted 3 lines

I started to experience random hangs of my laptop. Hardware info:
Thinkpad x60s 1704-5UG

the x60's chipset doesn't support ASPM properly afaik... bad idea.

Well, the code shouldn't then cause a crash of the machine :)

The user enabled it specifically (where it is disabled by default)

ASPM has been crashing e1000(e), which is why I've recently merged a patch to disable L1 ASPM for the onboard 82573 nic on those platforms.

this new infrastructure should work in the default configuration - enabling ASPM where this system leaves it disabled is expected to give problems unless you know what you are doing.

Auke

#4 lore raw
Quoted 11 lines
Quoted 10 lines
Quoted 8 lines
Quoted 6 lines

I've patched my kernel with the PCIe ASPM and after setting echo powersave > /sys/module/pcie_aspm/parameters/policy

I started to experience random hangs of my laptop. Hardware info:
Thinkpad x60s 1704-5UG

the x60's chipset doesn't support ASPM properly afaik... bad idea.

Well, the code shouldn't then cause a crash of the machine :)

Quoted 8 lines

The user enabled it specifically (where it is disabled by default)

ASPM has been crashing e1000(e), which is why I've recently merged a patch to disable L1 ASPM for the onboard 82573 nic on those platforms.

this new infrastructure should work in the default configuration - enabling ASPM where this system leaves it disabled is expected to give problems unless you know what you are doing.

In my defense, the patch documentation didn't say it doesn't work with my hardware, nor that it hangs the chipset :) and the promised 1.3w surelly looked nice.

So, are there any benefits of ASPM if I have it in the kernel but it's set to default? I got the impression that "default" means not much power savings?

Signature · 2 lines
Damjan Georgievski
Free Software Macedonia
#5 lore raw
Quoted 17 lines · ?????? ???????????
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Quoted 6 lines

I've patched my kernel with the PCIe ASPM and after setting echo powersave > /sys/module/pcie_aspm/parameters/policy

I started to experience random hangs of my laptop. Hardware info:
Thinkpad x60s 1704-5UG

the x60's chipset doesn't support ASPM properly afaik... bad idea.

Well, the code shouldn't then cause a crash of the machine :)

Quoted 8 lines

The user enabled it specifically (where it is disabled by default)

ASPM has been crashing e1000(e), which is why I've recently merged a patch to disable L1 ASPM for the onboard 82573 nic on those platforms.

this new infrastructure should work in the default configuration - enabling ASPM where this system leaves it disabled is expected to give problems unless you know what you are doing.

Quoted 6 lines

In my defense, the patch documentation didn't say it doesn't work with my hardware, nor that it hangs the chipset :) and the promised 1.3w surelly looked nice.

So, are there any benefits of ASPM if I have it in the kernel but it's set to default? I got the impression that "default" means not much power savings?

did the Kconfig not come with a big fat (EXPERIMENTAL) ?

it actually depends for each device on the PCI-Express bus. Most PCI-E ports support it but the device has the option of advertising enablement of that capability or not.

both platform and each device on the pci-e bus are involved. some sata chipsets work great with it, some that might not even advertise the capability... but it's really hit and miss.

Your report is great of course, no doubt about it. I hope that people understand that this feature can seriously break things at the bus level. It makes me feel a lot better about the issues we had with some of our network cards and ASPM :)

once we get some feeling about how good ASPM works in the field for people we might have to blacklist certain platforms or devices.

you could (for instance) try to see which device on your busses support ASPM and work on per-device ASPM parameters (which is one of the things I suggested before) so that we get an idea of which device is badly behaving with ASPM on your system.

Cheers,

Auke

#6 lore raw
Quoted 18 lines · Auke
Quoted 17 lines · ?????? ???????????
Quoted 16 lines
Quoted 8 lines
Quoted 7 lines
Quoted 6 lines

I've patched my kernel with the PCIe ASPM and after setting echo powersave > /sys/module/pcie_aspm/parameters/policy

I started to experience random hangs of my laptop. Hardware info:
Thinkpad x60s 1704-5UG

the x60's chipset doesn't support ASPM properly afaik... bad idea.

Well, the code shouldn't then cause a crash of the machine :)

The user enabled it specifically (where it is disabled by default)

ASPM has been crashing e1000(e), which is why I've recently merged a patch to disable L1 ASPM for the onboard 82573 nic on those platforms.

this new infrastructure should work in the default configuration - enabling ASPM where this system leaves it disabled is expected to give problems unless you know what you are doing.

Quoted 8 lines
Quoted 6 lines

In my defense, the patch documentation didn't say it doesn't work with my hardware, nor that it hangs the chipset :) and the promised 1.3w surelly looked nice.

So, are there any benefits of ASPM if I have it in the kernel but it's set to default? I got the impression that "default" means not much power savings?

did the Kconfig not come with a big fat (EXPERIMENTAL) ?

(EXPERIMENTAL) is something different from (KNOWN BROKEN).

If we know about broken setups, we should probably be blacklisting them.

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#7 lore raw
Quoted 26 lines · Pavel Machek
Quoted 25 lines · Auke
Quoted 23 lines · ?????? ???????????
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Quoted 6 lines

I've patched my kernel with the PCIe ASPM and after setting echo powersave > /sys/module/pcie_aspm/parameters/policy

I started to experience random hangs of my laptop. Hardware info:
Thinkpad x60s 1704-5UG

the x60's chipset doesn't support ASPM properly afaik... bad idea.

Well, the code shouldn't then cause a crash of the machine :)

Quoted 8 lines

The user enabled it specifically (where it is disabled by default)

ASPM has been crashing e1000(e), which is why I've recently merged a patch to disable L1 ASPM for the onboard 82573 nic on those platforms.

this new infrastructure should work in the default configuration - enabling ASPM where this system leaves it disabled is expected to give problems unless you know what you are doing.

In my defense, the patch documentation didn't say it doesn't work with my hardware, nor that it hangs the chipset :) and the promised 1.3w surelly looked nice.

So, are there any benefits of ASPM if I have it in the kernel but it's set to default? I got the impression that "default" means not much power savings?

Quoted 6 lines
Quoted 1 line

did the Kconfig not come with a big fat (EXPERIMENTAL) ?

(EXPERIMENTAL) is something different from (KNOWN BROKEN).

If we know about broken setups, we should probably be blacklisting them.

Well, the ASPM thing seems to break every single setup I've tested. So, perhaps we should whitelist the working ones?

Rafael

#8 lore raw
Quoted 25 lines · Rafael J. Wysocki
Quoted 24 lines · Pavel Machek
Quoted 23 lines · Auke
Quoted 22 lines · ?????? ???????????
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Quoted 6 lines

I've patched my kernel with the PCIe ASPM and after setting echo powersave > /sys/module/pcie_aspm/parameters/policy

I started to experience random hangs of my laptop. Hardware info:
Thinkpad x60s 1704-5UG

the x60's chipset doesn't support ASPM properly afaik... bad idea.

Well, the code shouldn't then cause a crash of the machine :)

Quoted 8 lines

The user enabled it specifically (where it is disabled by default)

ASPM has been crashing e1000(e), which is why I've recently merged a patch to disable L1 ASPM for the onboard 82573 nic on those platforms.

this new infrastructure should work in the default configuration - enabling ASPM where this system leaves it disabled is expected to give problems unless you know what you are doing.

In my defense, the patch documentation didn't say it doesn't work with my hardware, nor that it hangs the chipset :) and the promised 1.3w surelly looked nice.

So, are there any benefits of ASPM if I have it in the kernel but it's set to default? I got the impression that "default" means not much power savings?

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

did the Kconfig not come with a big fat (EXPERIMENTAL) ?

(EXPERIMENTAL) is something different from (KNOWN BROKEN).

If we know about broken setups, we should probably be blacklisting them.

Well, the ASPM thing seems to break every single setup I've tested. So, perhaps we should whitelist the working ones?

greg KH is reverting this patch alltogether in mainline, maybe the original writer can accomodate some of the comments in the rewrite.

Auke

#9 lore raw
Quoted 29 lines · Auke
Quoted 28 lines · Rafael J. Wysocki
Quoted 27 lines · Pavel Machek
Quoted 17 lines · Auke
Quoted 16 lines · ?????? ???????????
Quoted 16 lines
Quoted 8 lines
Quoted 7 lines
Quoted 6 lines

I've patched my kernel with the PCIe ASPM and after setting echo powersave > /sys/module/pcie_aspm/parameters/policy

I started to experience random hangs of my laptop. Hardware info:
Thinkpad x60s 1704-5UG

the x60's chipset doesn't support ASPM properly afaik... bad idea.

Well, the code shouldn't then cause a crash of the machine :)

The user enabled it specifically (where it is disabled by default)

ASPM has been crashing e1000(e), which is why I've recently merged a patch to disable L1 ASPM for the onboard 82573 nic on those platforms.

this new infrastructure should work in the default configuration - enabling ASPM where this system leaves it disabled is expected to give problems unless you know what you are doing.

Quoted 7 lines
Quoted 6 lines

In my defense, the patch documentation didn't say it doesn't work with my hardware, nor that it hangs the chipset :) and the promised 1.3w surelly looked nice.

So, are there any benefits of ASPM if I have it in the kernel but it's set to default? I got the impression that "default" means not much power savings?

did the Kconfig not come with a big fat (EXPERIMENTAL) ?

(EXPERIMENTAL) is something different from (KNOWN BROKEN).

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

If we know about broken setups, we should probably be blacklisting them.

Well, the ASPM thing seems to break every single setup I've tested. So, perhaps we should whitelist the working ones?

greg KH is reverting this patch alltogether in mainline, maybe the original writer can accomodate some of the comments in the rewrite.

It's already reverted.

thanks,

greg k-h

#10 lore raw
In reply to Дамјан Георгиевски
Quoted 8 lines · Дамјан Георгиевски

I've patched my kernel with the PCIe ASPM and after setting echo powersave > /sys/module/pcie_aspm/parameters/policy

I started to experience random hangs of my laptop. Hardware info:
Thinkpad x60s 1704-5UG
also tested on a firends X60s 1702-F6U

Quoted 4 lines

Kernel is 2.6.24 + these patches:
tuxonice 3.0-rc5
thinkpad_acpi v0.19-20080107
tp_smapi 0.36

Hi,
Sorry for the long delay, I'm just back from vocation. Some devices or chipsets don't work well with ASPM. This is one of the reason why the default policy of the patch is per BIOS setting. Ideally drivers should disable ASPM for specific devices, the patch provides an API (pci_disable_link_state) for this too. As Auke suggested, you can use the per-device interface to control separate links to see which device is broken. If you found one, please report to driver maintainer and me, we can disable ASPM in the driver.

Thanks,
Shaohua