Add HAVE_PLATFORM_PATA Kconfig
Subsystems (2)
cover Add HAVE_PLATFORM_PATA Kconfig
Repost of previous patch-set with email address in part 3 corrected.
PATCH 1/3 LIBATA: Add HAVE_PATA_PLATFORM to select PATA_PLATFORM driver
Add HAVE_PATA_PLATFORM to select the pata platform driver to ensure that we do not end up with a long 'depends on' list when other users of this driver turn up.
drivers/ata/Kconfig +9 -1
@@ -614,9 +614,17 @@ config PATA_WINBOND_VLB Support for the Winbond W83759A controller on Vesa Local Bus systems. +config HAVE_PATA_PLATFORM + bool + help + This is an internal configuration node for any machine that + uses pata-platform driver to enable the relevant driver in the + configuration structure without having to submit endless patches + to update the PATA_PLATFORM entry. + config PATA_PLATFORM tristate "Generic platform device PATA support" - depends on EMBEDDED || ARCH_RPC || PPC + depends on EMBEDDED || ARCH_RPC || PPC || HAVE_PATA_PLATFORM help This option enables support for generic directly connected ATA devices commonly found on embedded systems.
Signature · 3 lines
Ben ([email protected], http://www.fluff.org/) 'a smiley only costs 4 bytes'
PATCH 2/3 ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver
In reply to Ben DooksUse HAVE_PATA_PLATFORM for ARCH_RPC
PATCH FOLLOWS
KernelVersion: 2.6.24-git12
arch/arm/Kconfig +1 -0
@@ -371,6 +371,7 @@ config ARCH_RPC select FIQ select TIMER_ACORN select ARCH_MAY_HAVE_PC_FDC + select HAVE_PATA_PLATFORM select ISA_DMA_API select NO_IOPORT help
drivers/ata/Kconfig +1 -1
@@ -624,7 +624,7 @@ config HAVE_PATA_PLATFORM config PATA_PLATFORM tristate "Generic platform device PATA support" - depends on EMBEDDED || ARCH_RPC || PPC || HAVE_PATA_PLATFORM + depends on EMBEDDED || PPC || HAVE_PATA_PLATFORM help This option enables support for generic directly connected ATA devices commonly found on embedded systems.
Signature · 8 lines
Ben ([email protected], http://www.fluff.org/) 'a smiley only costs 4 bytes' ------------------------------------------------------------------- List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
Re: [PATCH 2/3 2.6.24-git] ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver
Quoted 5 lines · Ben Dooks
Use
HAVE_PATA_PLATFORMforARCH_RPCCc Linux ARM Kernel <[email protected]>Cc Russell King <[email protected]>Signed-off-by Ben Dooks <[email protected]>
Patch is fine.
Thanks.
PATCH 3/3 PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC
In reply to Ben DooksUse the new HAVE_PATA_PLATFORM to select PATA_PLATFORM driver.
arch/ppc/Kconfig +1 -0
@@ -41,6 +41,7 @@ config GENERIC_CALIBRATE_DELAY config PPC bool + select HAVE_PATA_PLATFORM default y config PPC32
drivers/ata/Kconfig +1 -1
@@ -624,7 +624,7 @@ config HAVE_PATA_PLATFORM config PATA_PLATFORM tristate "Generic platform device PATA support" - depends on EMBEDDED || PPC || HAVE_PATA_PLATFORM + depends on EMBEDDED || HAVE_PATA_PLATFORM help This option enables support for generic directly connected ATA devices commonly found on embedded systems.
Signature · 3 lines
Ben ([email protected], http://www.fluff.org/) 'a smiley only costs 4 bytes'
Re: [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC
Quoted 5 lines · Ben Dooks
Use the new
HAVE_PATA_PLATFORMto selectPATA_PLATFORMdriver.Signed-off-by Ben Dooks <[email protected]>
What tree is this against? It doesn't apply to current mainline nor jgarzik's libata-dev upstream branch.
Anyway: NACK: I like this approach but this needs to be added to arch/powerpc as well.
It's actually more needed there than arch/ppc, I don't personally care if arch/ppc can't use pata_platform for the last couple of months it's still around (it's getting deleted this summer, all platforms should have moved to powerpc by then).
-Olof
Re: [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC
Quoted 9 lines · Olof Johansson
Quoted 5 lines · Ben Dooks
Use the new
HAVE_PATA_PLATFORMto selectPATA_PLATFORMdriver.Signed-off-by Ben Dooks <[email protected]>What tree is this against? It doesn't apply to current mainline nor jgarzik's libata-dev upstream branch.
It is a series that i've just sent to the linux-ide list, only the ppc part was cc'd to the ppc list.
Quoted 2 lines
Anyway: NACK: I like this approach but this needs to be added to
arch/powerpcas well.
I can add that to the series.
Quoted 4 lines
It's actually more needed there than
arch/ppc, I don't personally care ifarch/ppccan't usepata_platformfor the last couple of months it's still around (it's getting deleted this summer, all platforms should have moved to powerpc by then).
Thanks, didn't know that.
Signature · 4 lines
Ben Q: What's a light-year? A: One-third less calories than a regular year.
Re: [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC
Quoted 5 lines · Ben Dooks
Quoted 4 lines · Olof Johansson
Quoted 3 lines · Ben Dooks
Use the new
HAVE_PATA_PLATFORMto selectPATA_PLATFORMdriver.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Ben Dooks <[email protected]>What tree is this against? It doesn't apply to current mainline nor jgarzik's libata-dev upstream branch.
It is a series that i've just sent to the linux-ide list, only the ppc part was cc'd to the ppc list.
D'oh. Ok, makes more sense now.
Are you planning on adding HAVE_PATA_PLATFORM to the other archs that use it as well, or keep it under EMBEDDED there?
Quoted 4 lines
Quoted 2 lines
Anyway: NACK: I like this approach but this needs to be added to
arch/powerpcas well.I can add that to the series.
Ok, cool. We can probably move it in under the relevant powerpc sub-platforms over time, and that's a powerpc-specific change anyway, no need to get that through linux-ide.
Quoted 6 lines
Quoted 4 lines
It's actually more needed there than
arch/ppc, I don't personally care ifarch/ppccan't usepata_platformfor the last couple of months it's still around (it's getting deleted this summer, all platforms should have moved to powerpc by then).Thanks, didn't know that.
No problem. :)
-Olof
Quoted 2 lines · Ben Dooks
Repost of previous patch-set with email address in part 3 corrected.
Did this get dropped in the noise, or where people awaiting changes to the ppc for this to be applied? It would be great if this could get applied in the next window.
Signature · 4 lines
Ben Q: What's a light-year? A: One-third less calories than a regular year.