Skip to contentSkip to conversation

Add HAVE_PLATFROM_PATA Kconfig

PATCH In review Ben Dooks 3 participants 7 messages Feb 2, 2008 – Feb 11, 2008

Subsystems (2)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

cover Add HAVE_PLATFROM_PATA Kconfig

This is a repost of the earlier patch series, modified to use HAVE_PATA_PLATFORM for the current kernel merge window for 2.6.25.

Signature · 1 line
Ben
author
#1 lore raw

PATCH 1/3 LIBATA: Add HAVE_PATA_PLATFORM to select PATA_PLATFORM driver

Add HAVE_PATA_PLATFORM to select the pata platform driver to ensure that we do not end up with a long 'depends on' list when other users of this driver turn up.

drivers/ata/Kconfig +9 -1
Index: linux-2.6.24-git12-pata/drivers/ata/Kconfig
===================================================================
@@ -614,9 +614,17 @@ config PATA_WINBOND_VLB
 	  Support for the Winbond W83759A controller on Vesa Local Bus
 	  systems.
 
+config HAVE_PATA_PLATFORM
+	bool
+	help
+	  This is an internal configuration node for any machine that
+	  uses pata-platform driver to enable the relevant driver in the
+	  configuration structure without having to submit endless patches
+	  to update the PATA_PLATFORM entry.
+
 config PATA_PLATFORM
 	tristate "Generic platform device PATA support"
-	depends on EMBEDDED || ARCH_RPC || PPC
+	depends on EMBEDDED || ARCH_RPC || PPC || HAVE_PATA_PLATFORM
 	help
 	  This option enables support for generic directly connected ATA
 	  devices commonly found on embedded systems.
Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'
author
#2 lore raw

PATCH 2/3 ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver

In reply to Ben Dooks

Use HAVE_PATA_PLATFORM for ARCH_RPC

Cc Linux ARM Kernel <[email protected]>
Cc Russell King <[email protected]>

PATCH FOLLOWS
KernelVersion: 2.6.24-git12

arch/arm/Kconfig +1 -0
Index: linux-2.6.24-git12-pata/arch/arm/Kconfig
===================================================================
@@ -371,6 +371,7 @@ config ARCH_RPC
 	select FIQ
 	select TIMER_ACORN
 	select ARCH_MAY_HAVE_PC_FDC
+	select HAVE_PATA_PLATFORM
 	select ISA_DMA_API
 	select NO_IOPORT
 	help
drivers/ata/Kconfig +1 -1
Index: linux-2.6.24-git12-pata/drivers/ata/Kconfig
===================================================================
@@ -624,7 +624,7 @@ config HAVE_PATA_PLATFORM
 
 config PATA_PLATFORM
 	tristate "Generic platform device PATA support"
-	depends on EMBEDDED || ARCH_RPC || PPC || HAVE_PATA_PLATFORM
+	depends on EMBEDDED || PPC || HAVE_PATA_PLATFORM
 	help
 	  This option enables support for generic directly connected ATA
 	  devices commonly found on embedded systems.
Signature · 8 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php
#3 lore raw

Re: [PATCH 2/3 2.6.24-git] ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver

ACK patch series... would it be ok to send via the ARM maintainer?

I would prefer to add this at the same time as its user...

#4 lore raw

Re: [PATCH 2/3 2.6.24-git] ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver

Quoted 3 lines · Jeff Garzik

ACK patch series... would it be ok to send via the ARM maintainer?

I would prefer to add this at the same time as its user...

I've only seen the one patch, and I suspect that it depends on patches to other architectures (to convert other architectures to use the new variable.)

author
#5 lore raw

Re: [PATCH 2/3 2.6.24-git] ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver

Quoted 8 lines · Russell King - ARM Linux
Quoted 3 lines · Jeff Garzik

ACK patch series... would it be ok to send via the ARM maintainer?

I would prefer to add this at the same time as its user...

I've only seen the one patch, and I suspect that it depends on patches to other architectures (to convert other architectures to use the new variable.)

Hmm, that is a difficult one. If I send it via RMK, then it assumes that Jeff applies the core patch first and gets his pull request off first. If I send via Jeff, I have to hope RMK doesn't try and modify any of the RPC code (unlikely, these machines have been out of production for a few years now).

Even worse, the rest of the patches have to also be applied in order as they remove from the depends line...

Signature · 4 lines
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.