Skip to contentSkip to conversation

net: NEWEMAC: Remove "rgmii-interface" from rgmii matching table

PATCH In review Stefan Roese 6 participants 7 messages Feb 6, 2008 – Feb 11, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: NEWEMAC: Remove "rgmii-interface" from rgmii matching table

With the removal the the "rgmii-interface" device_type property from the dts files, the newemac driver needs an update to only rely on compatible property.

---
 drivers/net/ibm_newemac/rgmii.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/ibm_newemac/rgmii.c +0 -1
index 9bc1132..5757788 100644
@@ -302,7 +302,6 @@ static int __devexit rgmii_remove(struct of_device *ofdev)
 static struct of_device_id rgmii_match[] =
 {
 	{
-		.type		= "rgmii-interface",
 		.compatible	= "ibm,rgmii",
 	},
 	{
Signature · 1 line
1.5.4.rc3
#2 lore raw
Quoted 11 lines · Josh Boyer
Quoted 6 lines · On Wed, 6 Feb 2008 13:21:59 +0100 Stefan Roese <[email protected]> wrote:

With the removal the the "rgmii-interface" device_type property from the dts files, the newemac driver needs an update to only rely on compatible property.

upon further reflection, ACK, take this via ppc tree

#3 lore raw
In reply to Stefan Roese
Quoted 3 lines · Stefan Roese

With the removal the the "rgmii-interface" device_type property from the dts files, the newemac driver needs an update to only rely on compatible property.

What about systems using an older dts, such as one kexec:ing from an older kernel?

Just because the device tree source is distributed in the kernel tree doesn't mean it can give up backwards compatibility.

-Olof

#4 lore raw
Quoted 7 lines · On Wed, 6 Feb 2008 10:01:57 -0600 Olof Johansson <[email protected]> wrote:
Quoted 3 lines · Stefan Roese

With the removal the the "rgmii-interface" device_type property from the dts files, the newemac driver needs an update to only rely on compatible property.

What about systems using an older dts, such as one kexec:ing from an older kernel?

Like what? Kexec doesn't work on 4xx yet.

Quoted 2 lines

Just because the device tree source is distributed in the kernel tree doesn't mean it can give up backwards compatibility.

We checked Axon, which is the only non-DTS machine that uses EMAC and it will work fine with this change.

josh

#5 lore raw
Quoted 4 lines · Josh Boyer
Quoted 1 line · On Wed, 6 Feb 2008 10:01:57 -0600 Olof Johansson <[email protected]> wrote:

On Wed, Feb 06, 2008 at 01:21:59PM +0100, Stefan Roese wrote:

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

With the removal the the "rgmii-interface" device_type property from the dts files, the newemac driver needs an update to only rely on compatible property.

What about systems using an older dts, such as one kexec:ing from an older kernel?

Like what? Kexec doesn't work on 4xx yet.

Sure, but similar restrictions would apply for customers who have a flashed device tree that want to boot a newer kernel. Deprecating old device tree support is something that should be done very carefully.

Quoted 5 lines
Quoted 2 lines

Just because the device tree source is distributed in the kernel tree doesn't mean it can give up backwards compatibility.

We checked Axon, which is the only non-DTS machine that uses EMAC and it will work fine with this change.

Ah, ok. I remember discussions about this patch before then, sounds like it's safe. I just triggered on the dts-centric patch description.

Objections withdrawn. :)

-Olof

#6 lore raw
Quoted 9 lines · Olof Johansson
Quoted 8 lines · Josh Boyer
Quoted 5 lines · On Wed, 6 Feb 2008 10:01:57 -0600 Olof Johansson <[email protected]> wrote:
Quoted 3 lines · Stefan Roese

With the removal the the "rgmii-interface" device_type property from the dts files, the newemac driver needs an update to only rely on compatible property.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

What about systems using an older dts, such as one kexec:ing from an older kernel?

Like what? Kexec doesn't work on 4xx yet.

Sure, but similar restrictions would apply for customers who have a flashed device tree that want to boot a newer kernel. Deprecating old device tree support is something that should be done very carefully.

In that case, we -know- there was no such thing as the proper support for 4xx in powerpc isn't really there before 2.6.25 anyway. The only other is Cell/Axon which we verified still works.

Ben.