Skip to contentSkip to conversation

sh: add byte support to the sign extension code

PATCH New Magnus Damm 1 participant 1 message Feb 7, 2008 SuperH

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sh: add byte support to the sign extension code

This patch adds byte support to the sign extension code. Unaligned access traps should never be generated on 8-bit io operations, but we will use this code for trapped io and we do need byte support there.

---

 arch/sh/kernel/traps_32.c |   12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
arch/sh/kernel/traps_32.c +11 -1
@@ -150,14 +150,24 @@ static int die_if_no_fixup(const char * 
 static inline void sign_extend(unsigned int count, unsigned char *dst)
 {
 #ifdef __LITTLE_ENDIAN__
+	if ((count = 1) && dst[0] & 0x80) {
+		dst[1] = 0xff;
+		dst[2] = 0xff;
+		dst[3] = 0xff;
+	}
 	if ((count = 2) && dst[1] & 0x80) {
 		dst[2] = 0xff;
 		dst[3] = 0xff;
 	}
 #else
-	if ((count = 2) && dst[2] & 0x80) {
+	if ((count = 1) && dst[3] & 0x80) {
+		dst[2] = 0xff;
+		dst[1] = 0xff;
 		dst[0] = 0xff;
+	}
+	if ((count = 2) && dst[2] & 0x80) {
 		dst[1] = 0xff;
+		dst[0] = 0xff;
 	}
 #endif
 }