Skip to contentSkip to conversation

out-of-bounds array index

DISCUSSION Jens Axboe 3 participants 6 messages Feb 7, 2008 Char and misc drivers

lore
Share & tools
lore

Jens Axboe

author
#0 lore raw

Hi,

Just saw this from gcc:

drivers/char/drm/i915_drv.c: In function ?i915_suspend?:
drivers/char/drm/i915_drv.c:173: warning: array subscript is above array bounds
CC [M] drivers/char/drm/i915_dma.o
drivers/char/drm/i915_drv.c: In function ?i915_resume?:
drivers/char/drm/i915_drv.c:220: warning: array subscript is above array bounds

It's this code:

        dev_priv->saveGR[0x18] =
                i915_read_indexed(VGA_GR_INDEX, VGA_GR_DATA, 0x18);

which looks legit, since saveGR is

        u8 saveGR[24];

It has been introduced by commit ba8bbcf6ff4650712f64c0ef61139c73898e2165, which seems to be you Jesse.

Signature · 1 line
Jens Axboe
#1 lore raw
Quoted 17 lines · Jens Axboe

Hi,

Just saw this from gcc:

drivers/char/drm/i915_drv.c: In function ?i915_suspend?:
drivers/char/drm/i915_drv.c:173: warning: array subscript is above array bounds
CC [M] drivers/char/drm/i915_dma.o
drivers/char/drm/i915_drv.c: In function ?i915_resume?:
drivers/char/drm/i915_drv.c:220: warning: array subscript is above array bounds

It's this code:

        dev_priv->saveGR[0x18] =
                i915_read_indexed(VGA_GR_INDEX, VGA_GR_DATA, 0x18);
Quoted 6 lines

which looks legit, since saveGR is

        u8 saveGR[24];

It has been introduced by commit ba8bbcf6ff4650712f64c0ef61139c73898e2165, which seems to be you Jesse.

I'll take a look, thanks.

Jesse

#2 lore raw
In reply to Jens Axboe
Quoted 17 lines · Jens Axboe

Hi,

Just saw this from gcc:

drivers/char/drm/i915_drv.c: In function ?i915_suspend?:
drivers/char/drm/i915_drv.c:173: warning: array subscript is above array bounds
CC [M] drivers/char/drm/i915_dma.o
drivers/char/drm/i915_drv.c: In function ?i915_resume?:
drivers/char/drm/i915_drv.c:220: warning: array subscript is above array bounds

It's this code:

        dev_priv->saveGR[0x18] =
                i915_read_indexed(VGA_GR_INDEX, VGA_GR_DATA, 0x18);
Quoted 6 lines

which looks legit, since saveGR is

        u8 saveGR[24];

It has been introduced by commit ba8bbcf6ff4650712f64c0ef61139c73898e2165, which seems to be you Jesse.

Just a silly off by one, don't know why I didn't catch it earlier. I'll push the fix to the drm tree. Linus, you may want to take it in parallel.

Jesse

Make sure we have enough room for all the GR registers or we'll end up clobbering the AR index register (which should actually be harmless unless the BIOS is making an assumption about it).

drivers/char/drm/i915_drv.h +1 -1
index 37bbf67..f8308bf 100644
@@ -187,7 +187,7 @@ typedef struct drm_i915_private {
 	u32 saveSWF2[3];
 	u8 saveMSR;
 	u8 saveSR[8];
-	u8 saveGR[24];
+	u8 saveGR[25];
 	u8 saveAR_INDEX;
 	u8 saveAR[20];
 	u8 saveDACMASK;
#3 lore raw
In reply to Jens Axboe
Quoted 11 lines · Jens Axboe

Just saw this from gcc:

drivers/char/drm/i915_drv.c: In function ?i915_suspend?:
drivers/char/drm/i915_drv.c:173: warning: array subscript is above array bounds
CC [M] drivers/char/drm/i915_dma.o
drivers/char/drm/i915_drv.c: In function ?i915_resume?:
drivers/char/drm/i915_drv.c:220: warning: array subscript is above array bounds

Quoted 6 lines

It's this code:

       dev_priv->saveGR[0x18] =
               i915_read_indexed(VGA_GR_INDEX, VGA_GR_DATA, 0x18);

which looks legit, since saveGR is

It is not legit at all. 0x18 is the 25th position in the array, but it is only 24 big. (Excluding play-hide-and-seek games like allocating more in case of malloc or char *foo[0].)

#4 lore raw
Quoted 13 lines · Jan Engelhardt
Quoted 12 lines · Jens Axboe

Just saw this from gcc:

drivers/char/drm/i915_drv.c: In function ?i915_suspend?:
drivers/char/drm/i915_drv.c:173: warning: array subscript is above array bounds
CC [M] drivers/char/drm/i915_dma.o
drivers/char/drm/i915_drv.c: In function ?i915_resume?:
drivers/char/drm/i915_drv.c:220: warning: array subscript is above array bounds

It's this code:

Quoted 8 lines
Quoted 4 lines
       dev_priv->saveGR[0x18] =
               i915_read_indexed(VGA_GR_INDEX, VGA_GR_DATA, 0x18);

which looks legit, since saveGR is

It is not legit at all. 0x18 is the 25th position in the array, but it is only 24 big. (Excluding play-hide-and-seek games like allocating more in case of malloc or char *foo[0].)

I think he was saying that the warning was legit. Anyway, my gcc isn't smart enough to emit warnings like this, maybe it's time to ugprade...

Jesse

author
#5 lore raw
Quoted 17 lines · Jesse Barnes
Quoted 16 lines · Jan Engelhardt
Quoted 15 lines · Jens Axboe

Just saw this from gcc:

drivers/char/drm/i915_drv.c: In function ?i915_suspend?:
drivers/char/drm/i915_drv.c:173: warning: array subscript is above array bounds
CC [M] drivers/char/drm/i915_dma.o
drivers/char/drm/i915_drv.c: In function ?i915_resume?:
drivers/char/drm/i915_drv.c:220: warning: array subscript is above array bounds

It's this code:

       dev_priv->saveGR[0x18] =
               i915_read_indexed(VGA_GR_INDEX, VGA_GR_DATA, 0x18);
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

which looks legit, since saveGR is

It is not legit at all. 0x18 is the 25th position in the array, but it is only 24 big. (Excluding play-hide-and-seek games like allocating more in case of malloc or char *foo[0].)

I think he was saying that the warning was legit. Anyway, my gcc isn't smart enough to emit warnings like this, maybe it's time to ugprade...

of course, the reference was to the warning (I do know C and array indexing 101 :-)

Signature · 1 line
Jens Axboe