Skip to contentSkip to conversation

make pr_debug() dynamic

PATCH In review Jason Baron 3 participants 5 messages Feb 7, 2008 – Feb 11, 2008

lore
Share & tools
lore
#0 lore raw

cover make pr_debug() dynamic

hi,

make the pr_debug() function dependent upon the new immediate infrastruture. Thus, b/c of the low runtime impact, we can dynamically enable/disable pr_debug withoug recompiling. Patch allows 'pr_debug=0/1' on the command line or via /proc/sys/debug/pr_debug.

thanks,

-Jason

#1 lore raw
Quoted 1 line · Jason Baron

make the pr_debug() function dependent upon the new immediate infrastruture.

What's wrong with klogd -c 8 or equivalent?

#2 lore raw
Quoted 6 lines · Joe Perches
Quoted 1 line · Jason Baron

make the pr_debug() function dependent upon the new immediate infrastruture.

What's wrong with klogd -c 8 or equivalent?

Setting the loglevel higher, will not make pr_debug() calls visible. The only way to make them visible right now, is by re-compiling the kernel.

-Jason

#3 lore raw
Quoted 8 lines · Jason Baron
Quoted 4 lines · Joe Perches
Quoted 1 line · Jason Baron

make the pr_debug() function dependent upon the new immediate infrastruture.

What's wrong with klogd -c 8 or equivalent?

Setting the loglevel higher, will not make pr_debug() calls visible. The only way to make them visible right now, is by re-compiling the kernel.

pr_debug() was IMHO meant to be a compile-time optimization to throw out debug messages most people do not want.

If you want to switch on/off debugging messages, use printk(KERN_DEBUG) [with klogd -c something] and not pr_debug!

#4 lore raw
Quoted 11 lines · Jan Engelhardt
Quoted 5 lines
Quoted 2 lines

What's wrong with klogd -c 8 or equivalent?

Setting the loglevel higher, will not make pr_debug() calls visible. The only way to make them visible right now, is by re-compiling the kernel.

pr_debug() was IMHO meant to be a compile-time optimization to throw out debug messages most people do not want.

If you want to switch on/off debugging messages, use printk(KERN_DEBUG) [with klogd -c something] and not pr_debug!

true, we could turn pr_debug() calls into printk(KERN_DEBUG) calls, but there is an overhead to all these extra printk functions calls. The way I have implemented pr_debug(), there is no function call at all, in the off case. To me pr_debug() is currently a compile option, b/c there is often a lot of overhead to having it on. Being able to turn pr_debug() calls off/on in a production environment, to get debugging data seems very valuable.

thanks,

-Jason