Skip to contentSkip to conversation

Possible bug fix in the ehci-hcd

PATCH In review Andy Shevchenko 2 participants 2 messages Feb 7, 2008 – Feb 8, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Possible bug fix in the ehci-hcd

Hi!

The Sequans company who produce WiMAX chips provides the USB driver and kthp addon driver. However the USB device doesn't work correctly.

Here is more true hack for Sequans SQN11x0 based modem.

P.S. For more details, please, ask Sequans staff (see Signed-off-by lines).

drivers/usb/host/ehci-q.c renamed from drivers/usb/host/ehci-q.c.orig +7 -1
@@ -750,8 +750,14 @@
 			info1 |= 1 << 14;	/* toggle from qtd */
 			info2 |= (EHCI_TUNE_MULT_HS << 30);
 		} else if (type == PIPE_BULK) {
+			struct usb_device_descriptor *desc = &urb->dev->descriptor;
 			info1 |= (EHCI_TUNE_RL_HS << 28);
-			info1 |= 512 << 16;	/* usb2 fixed maxpacket */
+			/* Special hook for SQN11x0 */
+			if (desc->idVendor == 0x148e && desc->idProduct == 0x0900) {
+				info1 |= max_packet (maxp) << 16;
+			} else {
+				info1 |= 512 << 16;	/* usb2 fixed maxpacket */
+			}
 			info2 |= (EHCI_TUNE_MULT_HS << 30);
 		} else {		/* PIPE_INTERRUPT */
 			info1 |= max_packet (maxp) << 16;
Signature · 2 lines
With best regards,
Andy Shevchenko.      mailto: [email protected]
#1 lore raw
Quoted 17 lines · Andy Shevchenko

Hi!

The Sequans company who produce WiMAX chips provides the USB driver and kthp addon driver. However the USB device doesn't work correctly.

Here is more true hack for Sequans SQN11x0 based modem.

P.S. For more details, please, ask Sequans staff (see Signed-off-by lines).

drivers/usb/host/ehci-q.c renamed from drivers/usb/host/ehci-q.c.orig +0 -0
@@ -750,8 +750,14 @@
 			info1 |= 1 << 14;	/* toggle from qtd */
 			info2 |= (EHCI_TUNE_MULT_HS << 30);

drivers/usb/host/ehci-q.c line 760

Quoted 10 lines
drivers/usb/host/ehci-q.c renamed from drivers/usb/host/ehci-q.c.orig +7 -1
 		} else if (type == PIPE_BULK) {
+			struct usb_device_descriptor *desc = &urb->dev->descriptor;
 			info1 |= (EHCI_TUNE_RL_HS << 28);
-			info1 |= 512 << 16;	/* usb2 fixed maxpacket */
+			/* Special hook for SQN11x0 */
+			if (desc->idVendor == 0x148e && desc->idProduct == 0x0900) {
+				info1 |= max_packet (maxp) << 16;
+			} else {
+				info1 |= 512 << 16;	/* usb2 fixed maxpacket */
+			}

We should not be adding hacks for a specific USB device to the host driver, that's just wrong.

The driver for the device itself should be fixed.

Do you, or anyone else have a pointer to the driver that is causing this problem?

Andrew, please drop this from your queue.

thanks,

greg k-h