Two comments on menuconfig usability
Hi all, [please to CC me]
There's two things I want to comment on regarding menuconfig:
1) I know of the purpose of oldconfig, but I prefer using menuconfig for upgrading to newer kernel versions, because most of the time, I would select the standard options for new features anyway. menuconfig has the "(NEW)" string at the end of a feature's description. However, I find that hard to see among all the names of various lenghts. My proposal would be to have an "N" or a "NEW" appear to the _left_ of the selection boxes, so that, browsing through the menus, one could more easily spot the interesting places.
2) When selecting "Ralink driver support" (CONFIG_RT2X00), the accompanying drivers (CONFIG_RT2400PCI, CONFIG_RT61PC, ...) appear unindented. They should be indented by four spaces.
Cheers!
~Mik
Signature · 3 lines
Intrinsically unobtrusive antidisestablishmentarianistic inclinations cause considerable psychotic devastation among exasperated and marginally discomposed ornithologists.
PATCH 1/1 wireless: rt2x00: fix driver menu indenting
Quoted 1 line · On Sat, 9 Feb 2008 16:23:06 +0100 Michael B=FCker wrote:
2) When selecting "Ralink driver support" (
CONFIG_RT2X00), the accomp=
anying=20
Quoted 1 line
drivers (
CONFIG_RT2400PCI,CONFIG_RT61PC, ...) appear unindented. The=
y should=20
Quoted 1 line
be indented by four spaces.
Yes, patch is below.
---
=46rom: Randy Dunlap <[email protected]>
Michael B=FCker <[email protected]> reports that the RT2x00 drivers are not indented as they should be, so use proper dependencies to make them be indented as expected.
--- drivers/net/wireless/rt2x00/Kconfig | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/net/wireless/rt2x00/Kconfig +0 -0
@@ -11,18 +11,17 @@ config RT2X00 will also be created. That library (when the driver is built as a module) will be called "rt2x00lib.ko".
=20
+if RT2X00
+
config RT2X00_LIB
tristate
- depends on RT2X00
=20
config RT2X00_LIB_PCI
tristate
- depends on RT2X00
select RT2X00_LIB
=20
config RT2X00_LIB_USB
tristate
- depends on RT2X00
select RT2X00_LIB
=20
config RT2X00_LIB_FIRMWARE
@@ -39,7 +38,7 @@ config RT2X00_LIB_RFKILL
=20
config RT2400PCI
tristate "Ralink rt2400 pci/pcmcia support"
- depends on RT2X00 && PCI
+ depends on PCI
select RT2X00_LIB_PCI
select EEPROM_93CX6
---help---
@@ -58,7 +57,7 @@ config RT2400PCI_RFKILL
=20
config RT2500PCI
tristate "Ralink rt2500 pci/pcmcia support"
- depends on RT2X00 && PCI
+ depends on PCI
select RT2X00_LIB_PCI
select EEPROM_93CX6
---help---
@@ -77,7 +76,7 @@ config RT2500PCI_RFKILL
=20
config RT61PCI
tristate "Ralink rt61 pci/pcmcia support"
- depends on RT2X00 && PCI
+ depends on PCI
select RT2X00_LIB_PCI
select RT2X00_LIB_FIRMWARE
select EEPROM_93CX6
@@ -97,7 +96,7 @@ config RT61PCI_RFKILL
=20
config RT2500USB
tristate "Ralink rt2500 usb support"
- depends on RT2X00 && USB
+ depends on USB
select RT2X00_LIB_USB
---help---
This is an experimental driver for the Ralink rt2500 wireless chip.
@@ -106,7 +105,7 @@ config RT2500USB
=20
config RT73USB
tristate "Ralink rt73 usb support"
- depends on RT2X00 && USB
+ depends on USB
select RT2X00_LIB_USB
select RT2X00_LIB_FIRMWARE
---help---
@@ -128,3 +127,4 @@ config RT2X00_DEBUG
---help---
Enable debugging output for all rt2x00 modules
=20
+endif
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Rt2400-devel] [PATCH] wireless: rt2x00: fix driver menu indenting
Quoted 3 lines · Randy Dunlap
On Sat, 9 Feb 2008 16:23:06 +0100 Michael B=FCker wrote:
=20Quoted 1 line
2) When selecting "Ralink driver support" (
CONFIG_RT2X00), the acco=
mpanying=20
Quoted 1 line
Quoted 1 line
drivers (
CONFIG_RT2400PCI,CONFIG_RT61PC, ...) appear unindented. T=
hey should=20
Quoted 9 lines
Quoted 1 line
be indented by four spaces.
=20
Yes, patch is below.
=20
---
From: Randy Dunlap <[email protected]>
=20
Michael B=FCker <[email protected]> reports that the RT2x00 drivers are not indented as they should be, so use proper dependencies to mak=
e
Quoted 3 lines
them be indented as expected.
=20Signed-off-by Randy Dunlap <[email protected]>
---
John,
Could you push this directly into wireless-2.6 and probably upstream as=
well.
Thanks.
Ivo
Quoted 57 lines
--- drivers/net/wireless/rt2x00/Kconfig | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)=20
drivers/net/wireless/rt2x00/Kconfig +0
-0@@ -11,18 +11,17 @@ config RT2X00 will also be created. That library (when the driver is built as a module) will be called "rt2x00lib.ko".=20
drivers/net/wireless/rt2x00/Kconfig +2
-1+if RT2X00 + config RT2X00_LIB tristate - depends on RT2X00=20
configRT2X00_LIB_PCIdrivers/net/wireless/rt2x00/Kconfig +0
-1tristate - depends on RT2X00 select RT2X00_LIB=20
configRT2X00_LIB_USBdrivers/net/wireless/rt2x00/Kconfig +0
-1tristate - depends on RT2X00 select RT2X00_LIB=20
configRT2X00_LIB_FIRMWAREdrivers/net/wireless/rt2x00/Kconfig +0
-0@@ -39,7 +38,7 @@ config RT2X00_LIB_RFKILL=20
config RT2400PCIdrivers/net/wireless/rt2x00/Kconfig +1
-1tristate "Ralink rt2400 pci/pcmcia support" - depends on RT2X00 && PCI + depends on PCI select RT2X00_LIB_PCI select EEPROM_93CX6 ---help---@@ -58,7 +57,7 @@ config RT2400PCI_RFKILL=20
config RT2500PCIdrivers/net/wireless/rt2x00/Kconfig +1
-1tristate "Ralink rt2500 pci/pcmcia support" - depends on RT2X00 && PCI + depends on PCI select RT2X00_LIB_PCI select EEPROM_93CX6 ---help---@@ -77,7 +76,7 @@ config RT2500PCI_RFKILL=20
config RT61PCIdrivers/net/wireless/rt2x00/Kconfig +1
-1tristate "Ralink rt61 pci/pcmcia support" - depends on RT2X00 && PCI + depends on PCI select RT2X00_LIB_PCI select RT2X00_LIB_FIRMWARE select EEPROM_93CX6@@ -97,7 +96,7 @@ config RT61PCI_RFKILL=20
config RT2500USB
drivers/net/wireless/rt2x00/Kconfig
Quoted 6 lines
drivers/net/wireless/rt2x00/Kconfig +1
-1tristate "Ralink rt2500 usb support" - depends on RT2X00 && USB + depends on USB select RT2X00_LIB_USB ---help--- This is an experimental driver for the Ralink rt2500 wireless chi=
p.
Quoted 12 lines
drivers/net/wireless/rt2x00/Kconfig +0
-0@@ -106,7 +105,7 @@ config RT2500USB=20
config RT73USBdrivers/net/wireless/rt2x00/Kconfig +1
-1tristate "Ralink rt73 usb support" - depends on RT2X00 && USB + depends on USB select RT2X00_LIB_USB select RT2X00_LIB_FIRMWARE ---help---@@ -128,3 +127,4 @@ config RT2X00_DEBUG ---help--- Enable debugging output for all rt2x00 modules
Quoted 4 lines
=20
+endif
=20
---------------------------------------------------------------------=
----
Quoted 8 lines
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Rt2400-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/rt2400-devel
=20
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Rt2400-devel] [PATCH] wireless: rt2x00: fix driver menu indenting
Quoted 4 lines · On Sun, 10 Feb 2008 20:03:25 +0100 Ivo van Doorn wrote:
Quoted 3 lines · Randy Dunlap
On Sat, 9 Feb 2008 16:23:06 +0100 Michael B=FCker wrote:
=20Quoted 1 line
2) When selecting "Ralink driver support" (
CONFIG_RT2X00), the ac=
companying=20
Quoted 1 line
Quoted 1 line
Quoted 1 line
drivers (
CONFIG_RT2400PCI,CONFIG_RT61PC, ...) appear unindented.=
They should=20
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
be indented by four spaces.
=20
Yes, patch is below.
=20
---
From: Randy Dunlap <[email protected]>
=20
Michael B=FCker <[email protected]> reports that the RT2x00 driver=
s
Quoted 1 line
Quoted 1 line
are not indented as they should be, so use proper dependencies to m=
ake
Quoted 9 lines
Quoted 3 lines
them be indented as expected.
=20Signed-off-by Randy Dunlap <[email protected]>=20
=20
---
John,
Could you push this directly into wireless-2.6 and probably upstream =
as well.
Quoted 4 lines
=20
Thanks.
=20
Ivo
John, do you have this patch queued somewhere?
Quoted 55 lines
Quoted 55 lines
--- drivers/net/wireless/rt2x00/Kconfig | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)=20
drivers/net/wireless/rt2x00/Kconfig +0
-0@@ -11,18 +11,17 @@ config RT2X00 will also be created. That library (when the driver is built as a module) will be called "rt2x00lib.ko".=20
drivers/net/wireless/rt2x00/Kconfig +2
-1+if RT2X00 + config RT2X00_LIB tristate - depends on RT2X00=20
configRT2X00_LIB_PCIdrivers/net/wireless/rt2x00/Kconfig +0
-1tristate - depends on RT2X00 select RT2X00_LIB=20
configRT2X00_LIB_USBdrivers/net/wireless/rt2x00/Kconfig +0
-1tristate - depends on RT2X00 select RT2X00_LIB=20
configRT2X00_LIB_FIRMWAREdrivers/net/wireless/rt2x00/Kconfig +0
-0@@ -39,7 +38,7 @@ config RT2X00_LIB_RFKILL=20
config RT2400PCIdrivers/net/wireless/rt2x00/Kconfig +1
-1tristate "Ralink rt2400 pci/pcmcia support" - depends on RT2X00 && PCI + depends on PCI select RT2X00_LIB_PCI select EEPROM_93CX6 ---help---@@ -58,7 +57,7 @@ config RT2400PCI_RFKILL=20
config RT2500PCIdrivers/net/wireless/rt2x00/Kconfig +1
-1tristate "Ralink rt2500 pci/pcmcia support" - depends on RT2X00 && PCI + depends on PCI select RT2X00_LIB_PCI select EEPROM_93CX6 ---help---@@ -77,7 +76,7 @@ config RT2500PCI_RFKILL=20
config RT61PCIdrivers/net/wireless/rt2x00/Kconfig +1
-1tristate "Ralink rt61 pci/pcmcia support" - depends on RT2X00 && PCI + depends on PCI select RT2X00_LIB_PCI select RT2X00_LIB_FIRMWARE select EEPROM_93CX6@@ -97,7 +96,7 @@ config RT61PCI_RFKILL
Quoted 8 lines
drivers/net/wireless/rt2x00/Kconfig
Quoted 8 lines
=20
config RT2500USBdrivers/net/wireless/rt2x00/Kconfig +1
-1tristate "Ralink rt2500 usb support" - depends on RT2X00 && USB + depends on USB select RT2X00_LIB_USB ---help--- This is an experimental driver for the Ralink rt2500 wireless c=
hip.
Quoted 6 lines
Quoted 6 lines
drivers/net/wireless/rt2x00/Kconfig +0
-0@@ -106,7 +105,7 @@ config RT2500USB=20
config RT73USBdrivers/net/wireless/rt2x00/Kconfig +1
-1tristate "Ralink rt73 usb support" - depends on RT2X00 && USB + depends on USB
Quoted 8 lines
Quoted 8 lines
drivers/net/wireless/rt2x00/Kconfig +0
-0select RT2X00_LIB_USB select RT2X00_LIB_FIRMWARE ---help---@@ -128,3 +127,4 @@ config RT2X00_DEBUG ---help--- Enable debugging output for all rt2x00 modules=20
+endif
---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Rt2400-devel] [PATCH] wireless: rt2x00: fix driver menu indenting
Quoted 6 lines · Randy Dunlap
On Sun, 10 Feb 2008 20:03:25 +0100 Ivo van Doorn wrote:
=20Quoted 4 lines · Randy Dunlap
Quoted 3 lines · On Sat, 9 Feb 2008 16:23:06 +0100 Michael B=FCker wrote:
=20
Quoted 1 line
2) When selecting "Ralink driver support" (
CONFIG_RT2X00), the =
accompanying=20
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
drivers (
CONFIG_RT2400PCI,CONFIG_RT61PC, ...) appear unindente=
d. They should=20
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
be indented by four spaces.
=20
Yes, patch is below.
=20
---
From: Randy Dunlap <[email protected]>
=20
Michael B=FCker <[email protected]> reports that the RT2x00 driv=
ers
Quoted 1 line
Quoted 1 line
Quoted 1 line
are not indented as they should be, so use proper dependencies to=
make
Quoted 9 lines
Quoted 9 lines
Quoted 3 lines
them be indented as expected.
=20Signed-off-by Randy Dunlap <[email protected]>=20
=20
---
John,
Could you push this directly into wireless-2.6 and probably upstrea=
m as well.
Quoted 6 lines
Quoted 4 lines
=20
Thanks.
=20
Ivo=20
John, do you have this patch queued somewhere?
It is in net-2.6.26.
commit 0d84d78db5bad848e385cbb1e4ae2ea1f5f27641
Author: Randy Dunlap <[email protected]> Date: Sun Feb 10 10:52:52 2008 -0800
wireless: rt2x00: fix driver menu indenting
Michael B=FCker <[email protected]> reports that the RT2x00 driver=
s
are not indented as they should be, so use proper dependencies to m=
ake
them be indented as expected.
Hth!
John
--=20
John W. Linville
[email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html