Skip to contentSkip to conversation

zd1211rw: Fix beacon filter flags thinko

PATCH In review Michael Buesch 2 participants 3 messages Feb 10, 2008 – Feb 11, 2008 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 zd1211rw: Fix beacon filter flags thinko

We must not clear the FIF_BCN_PRBRESP_PROMISC bit in the new_flags. The zd-driver does support sending beacons and probe responses to the host. What the flag does is say "Send me all beacons and probe responses". And we actually do that. We always do that, so we ignore the case when the bit is disabled. But that is fine. But we must not clear the flag, as that tells mac80211 that we do not support passing beacons and probe responses to the stack. And that's not true.

---

Should probably go -stable, too.

drivers/net/wireless/zd1211rw/zd_mac.c +1 -1
Index: wireless-2.6/drivers/net/wireless/zd1211rw/zd_mac.c
===================================================================
@@ -765,13 +765,13 @@ static void set_rx_filter_handler(struct
 	if (r)
 		dev_err(zd_mac_dev(mac), "set_rx_filter_handler error %d\n", r);
 }
 
 #define SUPPORTED_FIF_FLAGS \
 	(FIF_PROMISC_IN_BSS | FIF_ALLMULTI | FIF_FCSFAIL | FIF_CONTROL | \
-	FIF_OTHER_BSS)
+	FIF_OTHER_BSS | FIF_BCN_PRBRESP_PROMISC)
 static void zd_op_configure_filter(struct ieee80211_hw *hw,
 			unsigned int changed_flags,
 			unsigned int *new_flags,
 			int mc_count, struct dev_mc_list *mclist)
 {
 	struct zd_mc_hash hash;
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Michael Buesch

We must not clear the FIF_BCN_PRBRESP_PROMISC bit in the new_flags. The zd-driver does support sending beacons and probe responses to the host. What the flag does is say "Send me all beacons and probe responses". And we actually do that. We always do that, so we ignore the case when the bit is disabled. But that is fine. But we must not clear the flag, as that tells mac80211 that we do not support passing beacons and probe responses to the stack. And that's not true.

Good explanation. Maybe it's needed with the filter flags defines/the config_filter callback description?

Quoted 1 line
Quoted 3 lines

---

Should probably go -stable, too.

Unnecessary, I don't think we currently ever test the flag in mac80211.

johannes

#2 lore raw
Quoted 11 lines · On Monday 11 February 2008 13:53:51 Johannes Berg wrote:
Quoted 8 lines · Michael Buesch

We must not clear the FIF_BCN_PRBRESP_PROMISC bit in the new_flags. The zd-driver does support sending beacons and probe responses to the host. What the flag does is say "Send me all beacons and probe responses". And we actually do that. We always do that, so we ignore the case when the bit is disabled. But that is fine. But we must not clear the flag, as that tells mac80211 that we do not support passing beacons and probe responses to the stack. And that's not true.

Quoted 2 lines

Good explanation. Maybe it's needed with the filter flags defines/the config_filter callback description?

Yeah, I think so. Recent patches show that other people get it wrong, too. :) I think I will submit a patch later.

Signature · 1 line
Greetings Michael.