Skip to contentSkip to conversation

x86/visws: fix printk format warnings

PATCH In review Randy Dunlap 2 participants 2 messages Feb 11, 2008 – Feb 29, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/visws: fix printk format warnings

From: Randy Dunlap <[email protected]>

Fix visws printk format warnings:

/local/linsrc/linux-2.6.24-git15/arch/x86/mach-visws/traps.c:50: warning: format '%#lx' expects type 'long unsigned int', but argument 2 has type 'u32' /local/linsrc/linux-2.6.24-git15/arch/x86/mach-visws/traps.c:50: warning: format '%#lx' expects type 'long unsigned int', but argument 3 has type 'u32'

---
 arch/x86/mach-visws/traps.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
arch/x86/mach-visws/traps.c +3 -2
@@ -46,8 +46,9 @@ static __init void cobalt_init(void)
 	 */
 	set_fixmap(FIX_APIC_BASE, APIC_DEFAULT_PHYS_BASE);
 	setup_local_APIC();
-	printk(KERN_INFO "Local APIC Version %#lx, ID %#lx\n",
-		apic_read(APIC_LVR), apic_read(APIC_ID));
+	printk(KERN_INFO "Local APIC Version %#x, ID %#x\n",
+		(unsigned int)apic_read(APIC_LVR),
+		(unsigned int)apic_read(APIC_ID));
 
 	set_fixmap(FIX_CO_CPU, CO_CPU_PHYS);
 	set_fixmap(FIX_CO_APIC, CO_APIC_PHYS);
Acked-by on v1 1/1
#1 lore raw
Quoted 16 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix visws printk format warnings:

/local/linsrc/linux-2.6.24-git15/arch/x86/mach-visws/traps.c:50: warning: format '%#lx' expects type 'long unsigned int', but argument 2 has type 'u32' /local/linsrc/linux-2.6.24-git15/arch/x86/mach-visws/traps.c:50: warning: format '%#lx' expects type 'long unsigned int', but argument 3 has type 'u32'

---
 arch/x86/mach-visws/traps.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
arch/x86/mach-visws/traps.c +0 -0
@@ -46,8 +46,9 @@ static __init void cobalt_init(void)
 	 */

arch/x86/mach-visws/traps.c static __init void cobalt_init(void) · line 54

Quoted 10 lines
arch/x86/mach-visws/traps.c +3 -2
 	set_fixmap(FIX_APIC_BASE, APIC_DEFAULT_PHYS_BASE);
 	setup_local_APIC();
-	printk(KERN_INFO "Local APIC Version %#lx, ID %#lx\n",
-		apic_read(APIC_LVR), apic_read(APIC_ID));
+	printk(KERN_INFO "Local APIC Version %#x, ID %#x\n",
+		(unsigned int)apic_read(APIC_LVR),
+		(unsigned int)apic_read(APIC_ID));
 
 	set_fixmap(FIX_CO_CPU, CO_CPU_PHYS);
 	set_fixmap(FIX_CO_APIC, CO_APIC_PHYS);

Sorry for so late answer, I missed your mail somehow :(

Signature · 2 lines
Andrey Panin		| Linux and UNIX system administrator
[email protected]		| PGP key: wwwkeys.pgp.net