Skip to contentSkip to conversation

drivers/base: export (un)register_memory_notifier

PATCH RESEND In review Jan-Bernd Themann 3 participants 4 messages Feb 11, 2008

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 drivers/base: export (un)register_memory_notifier

Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system.

---
Hi Greg,

are you the right person to address this patch to?

Regards,
Jan-Bernd

 drivers/base/memory.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/base/memory.c +2 -0
index 7ae413f..1e1bd4c 100644
@@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
 {
         return blocking_notifier_chain_register(&memory_chain, nb);
 }
+EXPORT_SYMBOL(register_memory_notifier);
 
 void unregister_memory_notifier(struct notifier_block *nb)
 {
         blocking_notifier_chain_unregister(&memory_chain, nb);
 }
+EXPORT_SYMBOL(unregister_memory_notifier);
 
 /*
  * register_memory - Setup a sysfs device for a memory block
Signature · 1 line
1.5.2
#1 lore raw
Quoted 1 line · Jan-Bernd Themann

are you the right person to address this patch to?

You might want to check the top of the file. ;)

drivers/base/memory.c int register_memory_notifier(struct notifier_block *nb) · line 61

Quoted 13 lines
drivers/base/memory.c +2 -0
@@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
 {
         return blocking_notifier_chain_register(&memory_chain, nb);
 }
+EXPORT_SYMBOL(register_memory_notifier);
 
 void unregister_memory_notifier(struct notifier_block *nb)
 {
         blocking_notifier_chain_unregister(&memory_chain, nb);
 }
+EXPORT_SYMBOL(unregister_memory_notifier);

Is there a particular reason these can't be GPL?

-- Dave

#2 lore raw
Quoted 13 lines · Dave Hansen
Quoted 1 line · Jan-Bernd Themann

are you the right person to address this patch to?

You might want to check the top of the file. ;)

Quoted 8 lines
drivers/base/memory.c +1 -0
@@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
 {
         return blocking_notifier_chain_register(&memory_chain, nb);
 }
+EXPORT_SYMBOL(register_memory_notifier);
 
Quoted 8 lines

drivers/base/memory.c int register_memory_notifier(struct notifier_block *nb) · line 61

Quoted 5 lines
drivers/base/memory.c +1 -0
 void unregister_memory_notifier(struct notifier_block *nb)
 {
         blocking_notifier_chain_unregister(&memory_chain, nb);
 }
+EXPORT_SYMBOL(unregister_memory_notifier);

Is there a particular reason these can't be GPL?

I don't object to make them GPL. Greg, what do you think?

Regards,
Jan-Bernd

#3 lore raw
Quoted 23 lines · Jan-Bernd Themann
Quoted 13 lines · Dave Hansen
Quoted 1 line · Jan-Bernd Themann

are you the right person to address this patch to?

You might want to check the top of the file. ;)

Quoted 8 lines
drivers/base/memory.c +1 -0
@@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
 {
         return blocking_notifier_chain_register(&memory_chain, nb);
 }
+EXPORT_SYMBOL(register_memory_notifier);
 
Quoted 8 lines

drivers/base/memory.c int register_memory_notifier(struct notifier_block *nb) · line 61

Quoted 5 lines
drivers/base/memory.c +1 -0
 void unregister_memory_notifier(struct notifier_block *nb)
 {
         blocking_notifier_chain_unregister(&memory_chain, nb);
 }
+EXPORT_SYMBOL(unregister_memory_notifier);

Is there a particular reason these can't be GPL?

Quoted 1 line

I don't object to make them GPL. Greg, what do you think?

They should be _GPL to match the rest of the driver core.

Care to resend this?

thanks,

greg k-h