Skip to contentSkip to conversation

drivers/base: export gpl (un)register_memory_notifier

PATCH In review Jan-Bernd Themann 3 participants 3 messages Feb 11, 2008

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/base: export gpl (un)register_memory_notifier

Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system.

---
Hi,

this is the modified version with EXPORT_SYMBOL_GPL

Regards,
Jan-Bernd

 drivers/base/memory.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/base/memory.c +2 -0
index 7ae413f..f5a0bf1 100644
@@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
 {
         return blocking_notifier_chain_register(&memory_chain, nb);
 }
+EXPORT_SYMBOL_GPL(register_memory_notifier);
 
 void unregister_memory_notifier(struct notifier_block *nb)
 {
         blocking_notifier_chain_unregister(&memory_chain, nb);
 }
+EXPORT_SYMBOL_GPL(unregister_memory_notifier);
 
 /*
  * register_memory - Setup a sysfs device for a memory block
Signature · 1 line
1.5.2
#1 lore raw
Quoted 3 lines · Jan-Bernd Themann

Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system.

Can you please add proper kernel-doc formatted comments when you export a symbol so others can get a clue what the exported function is supposed to do.

Sam

#2 lore raw
In reply to Jan-Bernd Themann
Quoted 3 lines · Jan-Bernd Themann

Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system.

Could you post this with the new users as well so we can make sure they're not abusing this in some way?

-- Dave