Skip to contentSkip to conversation

: avoid unneccessary use of xchg() in set_mb()

M68KNOMMU Greg Ungerer 1 participant 1 message Feb 12, 2008

lore
Share & tools
lore
#0 lore raw

Avoid unneccessary use of xchg() in set_mb().

---

include/asm-m68knommu/system.h +1 -1
diff -Naurp linux-2.6.25-rc1/include/asm-m68knommu/system.h linux-2.6.x/include/asm-m68knommu/system.h
@@ -104,7 +104,7 @@ asmlinkage void resume(void);
 #define mb()   asm volatile (""   : : :"memory")
 #define rmb()  asm volatile (""   : : :"memory")
 #define wmb()  asm volatile (""   : : :"memory")
-#define set_mb(var, value) do { xchg(&var, value); } while (0)
+#define set_mb(var, value)	({ (var) = (value); wmb(); })
 
 #ifdef CONFIG_SMP
 #define smp_mb()	mb()