Skip to contentSkip to conversation

Core driver for WM97xx touchscreens

PATCH Pete MacKay 2 participants 2 messages Feb 12, 2008

lore
Share & tools
lore
#0 lore raw

In wm97xx-core.c, should

Quoted 1 line

+int wm97xx_resume(struct device *dev)

be static?

Also, should

Review

Quoted 1 line
(quoted diff) +1 -0
+		if (wm->ts_use_count) {

have been changed to

Review

Quoted 1 line
(quoted diff) +1 -0
+		if (wm->input_dev->users) {

in this revised revision?

(Oops, that was repetitively redundant. :)

#1 lore raw
Quoted 7 lines · Pete MacKay

In wm97xx-core.c, should

Quoted 1 line

+int wm97xx_resume(struct device *dev)

be static?

Also, should

Yes, and in fact I had both fixes present in the development branch but had forgotten to cherry pick them over into the upstream branch - thanks for noticing, I'll respin.