Skip to contentSkip to conversation

Configure out DMI scanning code v2 (Linux Tiny)

PATCH In review Thomas Petazzoni 5 participants 6 messages Feb 12, 2008 – Apr 1, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Configure out DMI scanning code v2 (Linux Tiny)

Hi,

Enclosed patch is an updated version, with proper credits to Matt Mackall and the Linux Tiny project.

Sincerly,

Thomas

---

Turn CONFIG_DMI into a selectable option if EMBEDDED is defined, in order to be able to remove the DMI table scanning code if it's not needed, and then reduce the kernel code size.

With CONFIG_DMI (i.e before) :

text data bss dec hex filename
1076076 128656 98304 1303036 13e1fc vmlinux

Without CONFIG_DMI (i.e after) :

text data bss dec hex filename
1068092 126308 98304 1292704 13b9a0 vmlinux

Result:

text data bss dec hex filename
-7984 -2348 0 -10332 -285c vmlinux

The new option appears in "Processor type and features", only when CONFIG_EMBEDDED is defined.

This patch is part of the Linux Tiny project, and is based on previous work done by Matt Mackall <[email protected]>.

---
 arch/x86/Kconfig    |   12 +++++++++---
 include/linux/dmi.h |    1 +
 2 files changed, 10 insertions(+), 3 deletions(-)
arch/x86/Kconfig +9 -3
Index: linux/arch/x86/Kconfig
===================================================================
@@ -88,9 +88,6 @@
 config ARCH_MAY_HAVE_PC_FDC
 	def_bool y
 
-config DMI
-	def_bool y
-
 config RWSEM_GENERIC_SPINLOCK
 	def_bool !X86_XADD
 
@@ -433,6 +430,15 @@
 
 # Mark as embedded because too many people got it wrong.
 # The code disables itself when not needed.
+config DMI
+	default y
+	bool "Enable DMI scanning" if EMBEDDED
+	help
+	  Enabled scanning of DMI to identify machine quirks. Say Y
+	  here unless you have verified that your setup is not
+	  affected by entries in the DMI blacklist. Required by PNP
+	  BIOS code.
+
 config GART_IOMMU
 	bool "GART IOMMU support" if EMBEDDED
 	default y
include/linux/dmi.h +1 -0
Index: linux/include/linux/dmi.h
===================================================================
@@ -90,6 +90,7 @@
 static inline const char * dmi_get_system_info(int field) { return NULL; }
 static inline const struct dmi_device * dmi_find_device(int type, const char *name,
 	const struct dmi_device *from) { return NULL; }
+static inline void dmi_scan_machine(void) { return; }
 static inline int dmi_get_year(int year) { return 0; }
 static inline int dmi_name_in_vendors(const char *s) { return 0; }
 #define dmi_available 0
Signature · 4 lines
Thomas Petazzoni, Free Electrons
Free Embedded Linux Training Materials
on http://free-electrons.com/training
(More than 1500 pages!)
Acked-by on v1 1/1
#1 lore raw
Quoted 19 lines · Thomas Petazzoni

Turn CONFIG_DMI into a selectable option if EMBEDDED is defined, in order to be able to remove the DMI table scanning code if it's not needed, and then reduce the kernel code size.

With CONFIG_DMI (i.e before) :

text data bss dec hex filename
1076076 128656 98304 1303036 13e1fc vmlinux

Without CONFIG_DMI (i.e after) :

text data bss dec hex filename
1068092 126308 98304 1292704 13b9a0 vmlinux

Result:

text data bss dec hex filename
-7984 -2348 0 -10332 -285c vmlinux

Quoted 7 lines

The new option appears in "Processor type and features", only when CONFIG_EMBEDDED is defined.

This patch is part of the Linux Tiny project, and is based on previous work done by Matt Mackall <[email protected]>.

Thanks for working on this.

Signature · 1 line
Mathematics is the supreme nostalgia of our time.
#2 lore raw
Quoted 17 lines · On Tue, 12 Feb 2008 12:56:45 -0600 Matt Mackall <[email protected]> wrote:
Quoted 14 lines · Thomas Petazzoni

Turn CONFIG_DMI into a selectable option if EMBEDDED is defined, in order to be able to remove the DMI table scanning code if it's not needed, and then reduce the kernel code size.

With CONFIG_DMI (i.e before) :

text data bss dec hex filename
1076076 128656 98304 1303036 13e1fc vmlinux

Without CONFIG_DMI (i.e after) :

text data bss dec hex filename
1068092 126308 98304 1292704 13b9a0 vmlinux

Quoted 7 lines
Quoted 7 lines

Result:

text data bss dec hex filename
-7984 -2348 0 -10332 -285c vmlinux

The new option appears in "Processor type and features", only when CONFIG_EMBEDDED is defined.

Given this:

Quoted 5 lines
Quoted 2 lines

This patch is part of the Linux Tiny project, and is based on previous work done by Matt Mackall <[email protected]>.

That should have been "Signed-off-by:". I'll speculatively make that change.

Acked-by
#3 lore raw
Quoted 30 lines · Andrew Morton
Quoted 17 lines · On Tue, 12 Feb 2008 12:56:45 -0600 Matt Mackall <[email protected]> wrote:
Quoted 14 lines · Thomas Petazzoni

Turn CONFIG_DMI into a selectable option if EMBEDDED is defined, in order to be able to remove the DMI table scanning code if it's not needed, and then reduce the kernel code size.

With CONFIG_DMI (i.e before) :

text data bss dec hex filename
1076076 128656 98304 1303036 13e1fc vmlinux

Without CONFIG_DMI (i.e after) :

text data bss dec hex filename
1068092 126308 98304 1292704 13b9a0 vmlinux

Quoted 7 lines
Quoted 7 lines

Result:

text data bss dec hex filename
-7984 -2348 0 -10332 -285c vmlinux

The new option appears in "Processor type and features", only when CONFIG_EMBEDDED is defined.

Given this:

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

This patch is part of the Linux Tiny project, and is based on previous work done by Matt Mackall <[email protected]>.

That should have been "Signed-off-by:". I'll speculatively make that change.

for the x86 bits:

Ingo

#4 lore raw
In reply to Thomas Petazzoni

Question for Ingo...

Quoted 60 lines · On Tue, 12 Feb 2008 10:04:18 +0100 Thomas Petazzoni…

Hi,

Enclosed patch is an updated version, with proper credits to Matt Mackall and the Linux Tiny project.

Sincerly,

Thomas

---

Turn CONFIG_DMI into a selectable option if EMBEDDED is defined, in order to be able to remove the DMI table scanning code if it's not needed, and then reduce the kernel code size.

With CONFIG_DMI (i.e before) :

text data bss dec hex filename
1076076 128656 98304 1303036 13e1fc vmlinux

Without CONFIG_DMI (i.e after) :

text data bss dec hex filename
1068092 126308 98304 1292704 13b9a0 vmlinux

Result:

text data bss dec hex filename
-7984 -2348 0 -10332 -285c vmlinux

The new option appears in "Processor type and features", only when CONFIG_EMBEDDED is defined.

This patch is part of the Linux Tiny project, and is based on previous work done by Matt Mackall <[email protected]>.

---
 arch/x86/Kconfig    |   12 +++++++++---
 include/linux/dmi.h |    1 +
 2 files changed, 10 insertions(+), 3 deletions(-)

Index: linux/arch/x86/Kconfig
===================================================================

arch/x86/Kconfig +0 -3
@@ -88,9 +88,6 @@
 config ARCH_MAY_HAVE_PC_FDC
 	def_bool y
 
-config DMI
-	def_bool y
-
 config RWSEM_GENERIC_SPINLOCK
 	def_bool !X86_XADD
 
@@ -433,6 +430,15 @@
 
 # Mark as embedded because too many people got it wrong.

arch/x86/Kconfig line 441

Quoted 10 lines
arch/x86/Kconfig +9 -0
 # The code disables itself when not needed.
+config DMI
+	default y
+	bool "Enable DMI scanning" if EMBEDDED
+	help
+	  Enabled scanning of DMI to identify machine quirks. Say Y
+	  here unless you have verified that your setup is not
+	  affected by entries in the DMI blacklist. Required by PNP
+	  BIOS code.
+

This introduces a build error in drivers/acpi/thermal.c, because that code does:

#ifdef CONFIF_DMI
<define some tables>
#endif

	...
	dmi_check_system(<those tables>);

Now, the approved fix here is to just remove the ifdefs. The !CONFIG_DMI version of dmi_check_system() won't generate any references to the tables and the build system is then supposed to remove the generated code and data from vmlinux.

But this doesn't work.

When I add an ifdef around the dmi_check_system() call, I get

text data bss dec hex filename
1614279 210524 159992 1984795 1e491b vmlinux

but when I remove the ifdefs around the tables and rely on the compiler removing the code and data I get

text data bss dec hex filename
1614447 210972 159992 1985411 1e4b83 vmlinux

An additional 616 bytes of useless stuff.

Ingo, I think there was some trick to making this work right. Do you recall?

#5 lore raw
Quoted 6 lines · On Tuesday 01 April 2008 14:00:36 Andrew Morton wrote:

text data bss dec hex filename
1614279 210524 159992 1984795 1e491b vmlinux

but when I remove the ifdefs around the tables and rely on the compiler removing the code and data I get

Quoted 7 lines

text data bss dec hex filename
1614447 210972 159992 1985411 1e4b83 vmlinux

An additional 616 bytes of useless stuff.

Ingo, I think there was some trick to making this work right. Do you recall?

Does bloat-o-meter say what the additional 616 bytes _is_?

scripts/bloat-o-meter vmlinux.old vmlinux.new

P.S. What busybox did:

    ifneq ($(strip $(CONFIG_DEBUG)),y)
        OPTIMIZATION+=$(call check_cc,
$(CC),-ffunction-sections -fdata-sections,)
        CHECKED_LDFLAGS += $(call check_ld,$(LD),--gc-sections,)
    endif

Tells gcc to put each function and each global into its own ELF section, and then told the linker to garbage collect unused sections...

Rob

Signature · 2 lines
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.