Skip to contentSkip to conversation

hwmon: (w83l785ts) Don't ask the user to

PATCH In review Jean Delvare 2 participants 2 messages Feb 12, 2008 – Feb 26, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (w83l785ts) Don't ask the user to

There's nothing we can do about read errors on the W83L785TS-S, so don't ask the user to report them.

---
 Documentation/hwmon/w83l785ts |    3 ++-
 drivers/hwmon/w83l785ts.c     |    4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)
Documentation/hwmon/w83l785ts +2 -1
@@ -33,7 +33,8 @@ Known Issues
 ------------
 
 On some systems (Asus), the BIOS is known to interfere with the driver
-and cause read errors. The driver will retry a given number of times
+and cause read errors. Or maybe the W83L785TS-S chip is simply unreliable,
+we don't really know. The driver will retry a given number of times
 (5 by default) and then give up, returning the old value (or 0 if
 there is no old value). It seems to work well enough so that you should
 not notice anything. Thanks to James Bolt for helping test this feature.
drivers/hwmon/w83l785ts.c +2 -2
@@ -301,8 +301,8 @@ static u8 w83l785ts_read_value(struct i2
 		msleep(i);
 	}
 
-	dev_err(&client->dev, "Couldn't read value from register 0x%02x. "
-		"Please report.\n", reg);
+	dev_err(&client->dev, "Couldn't read value from register 0x%02x.\n",
+		reg);
 	return defval;
 }
 
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#1 lore raw

Re: [lm-sensors] [PATCH] hwmon: (w83l785ts) Don't ask the user

Hi Jean:

Quoted 8 lines · Jean Delvare

There's nothing we can do about read errors on the W83L785TS-S, so don't ask the user to report them.

---
 Documentation/hwmon/w83l785ts |    3 ++-
 drivers/hwmon/w83l785ts.c     |    4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

Applied to hwmon-2.6.git/testing, thanks.

Signature · 8 lines
Mark M. Hoffman
[email protected]


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors