Skip to contentSkip to conversation

Fix input parsing to support more than 9 flow id's correctly

PATCH In review PJ Waskiewicz 2 participants 4 messages Feb 13, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix input parsing to support more than 9 flow id's correctly

From: PJ Waskiewicz <[email protected]>

Using strtoul with a base of 16 converts flowid 10 into 0x10, which makes it flowid 16. This is interpreted by the kernel incorrectly, and causes traffic flows above 9 to be classified into band 0 on multiband qdiscs. This changes the base to 10, which will correctly parse input into the proper hexidecimal value.

---

 tc/tc_util.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
tc/tc_util.c +2 -2
index cdbae42..a277eac 100644
@@ -65,7 +65,7 @@ int get_tc_classid(__u32 *h, const char *str)
 	maj = TC_H_UNSPEC;
 	if (strcmp(str, "none") == 0)
 		goto ok;
-	maj = strtoul(str, &p, 16);
+	maj = strtoul(str, &p, 10);
 	if (p == str) {
 		maj = 0;
 		if (*p != ':')
@@ -76,7 +76,7 @@ int get_tc_classid(__u32 *h, const char *str)
 			return -1;
 		maj <<= 16;
 		str = p+1;
-		min = strtoul(str, &p, 16);
+		min = strtoul(str, &p, 10);
 		if (*p != 0)
 			return -1;
 		if (min >= (1<<16))
#1 lore raw

RE: [PATCH] [TC U32] Fix input parsing to support more than 9 flow id'scorrectly

Quoted 8 lines

From: PJ Waskiewicz <[email protected]>

Using strtoul with a base of 16 converts flowid 10 into 0x10, which makes it flowid 16. This is interpreted by the kernel incorrectly, and causes traffic flows above 9 to be classified into band 0 on multiband qdiscs.
This changes the base to 10, which will correctly parse input into the proper hexidecimal value.

Stephen,
We can go one of two ways I suppose. Once is this way, since
most user input for CLASSID is base 10, or we can update documentation to say that CLASSID input is expected to be base 16. What do you think?

Thanks,
-PJ Waskiewicz
[email protected]

Quoted 34 lines

---

 tc/tc_util.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
tc/tc_util.c +2 -3
@@ -65,7 +65,7 @@ int get_tc_classid(__u32 *h, const char *str)
 	maj = TC_H_UNSPEC;
 	if (strcmp(str, "none") == 0)
 		goto ok;
-	maj = strtoul(str, &p, 16);
+	maj = strtoul(str, &p, 10);
 	if (p == str) {
 		maj = 0;
 		if (*p != ':')
@@ -76,7 +76,7 @@ int get_tc_classid(__u32 *h, const char *str)
 			return -1;
 		maj <<= 16;
 		str = p+1;
-		min = strtoul(str, &p, 16);
+		min = strtoul(str, &p, 10);
 		if (*p != 0)
 			return -1;
 		if (min >= (1<<16))
 
--

To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw

Re: [PATCH] [TC U32] Fix input parsing to support more than 9 flow id'scorrectly

Quoted 6 lines · Peter P
Quoted 5 lines

From: PJ Waskiewicz <[email protected]>

Using strtoul with a base of 16 converts flowid 10 into 0x10, which makes it flowid 16. This is interpreted by the kernel incorrectly, and causes traffic flows above 9 to be classified into band 0 on multiband qdiscs. This changes the base to 10, which will correctly parse input into the proper hexidecimal value.

Quoted 10 lines

Stephen,
We can go one of two ways I suppose. Once is this way, since
most user input for CLASSID is base 10, or we can update documentation to say that CLASSID input is expected to be base 16. What do you think?

Thanks,
-PJ Waskiewicz
[email protected]

Sorry, can't change the api, update the documentation instead.

#3 lore raw

RE: [PATCH] [TC U32] Fix input parsing to support more than 9 flow id'scorrectly

Quoted 2 lines

Sorry, can't change the api, update the documentation instead.

Yes, this is much more reasonable. I'll send a patch shortly to do that.

Thanks
-PJ Waskiewicz