Skip to contentSkip to conversation

make secmark_tg_destroy() static

PATCH Applied Adrian Bunk 4 participants 5 messages Feb 13, 2008 – Feb 14, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make secmark_tg_destroy() static

This patch makes the needlessly global secmark_tg_destroy() static.

---
df66d8d74309b41298ae011532fd284aad3ed2ba

net/netfilter/xt_SECMARK.c +1 -1
index 7708e20..c028485 100644
@@ -111,7 +111,7 @@ secmark_tg_check(const char *tablename, const void *entry,
 	return true;
 }
 
-void secmark_tg_destroy(const struct xt_target *target, void *targinfo)
+static void secmark_tg_destroy(const struct xt_target *target, void *targinfo)
 {
 	switch (mode) {
 	case SECMARK_MODE_SEL:
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Adrian Bunk

This patch makes the needlessly global secmark_tg_destroy() static.

Thanks for catching this.

Quoted 15 lines

---
df66d8d74309b41298ae011532fd284aad3ed2ba

net/netfilter/xt_SECMARK.c +0 -1
index 7708e20..c028485 100644
@@ -111,7 +111,7 @@ secmark_tg_check(const char *tablename, const
 void *entry, return true;
 }
 
-void secmark_tg_destroy(const struct xt_target *target, void
 *targinfo) +static void secmark_tg_destroy(const struct xt_target
 *target, void *targinfo) {
 	switch (mode) {
 	case SECMARK_MODE_SEL:
Signature · 2 lines
paul moore
linux security @ hp
maintainer
#3 lore raw

From: James Morris <[email protected]>
Date: Thu, 14 Feb 2008 10:41:19 +1100 (EST)

Quoted 5 lines · Paul Moore
Quoted 4 lines · Adrian Bunk
Quoted 2 lines

This patch makes the needlessly global secmark_tg_destroy() static.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Thanks for catching this.

Applied -- will push to Linus unless the netfilter folk do it first.

I sucked it in, don't worry about it.